Add Pollard’s Rho algorithm for discrete logarithm #13657
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
- Added Wikipedia URL for Pollard's rho algorithm for logarithms - Removed unused Tuple import - All doctests and unit tests pass
- Replace generic parameter names (g, h, p) with descriptive names (base, target, modulus) - Replace generic function name 'f' with 'pseudo_random_function' - Add proper type hints for all parameters and return values - Replace single-letter variables with descriptive names throughout - Maintain backward compatibility with positional arguments - All tests and doctests continue to pass
sonianuj287
force-pushed
the
pollard_rho_discrete_log
branch
from
e958476 to
b31cc12
Compare
algorithms-keeper
bot
removed
require descriptive names
saha2997
approved these changes
Oct 21, 2025
- Use modern type hint syntax (int | None instead of Optional[int]) - Fix import order (removed unused typing import) - Fix line length issues by breaking long lines - Remove trailing whitespace and blank line whitespace - Replace unittest assertions with regular assert statements - Fix unused variable issues - Rename unused loop variables to _variable - Add missing newlines at end of files - All ruff checks now pass while maintaining functionality
sonianuj287
force-pushed
the
pollard_rho_discrete_log
branch
from
1b909d7 to
b241790
Compare
algorithms-keeper
bot
removed
the
tests are failing
|
Hi @MaximSmolskiy , could you please look to this issue and the PR i've raised. Thanks :) |
|
Hi , please review this PR and suggest me changes. Thanks :) |
|
How is this different than maths/pollard_rho.py? Different? More readable? Faster? |
cclauss
reviewed
Oct 23, 2025
Comment on lines
+19
to
+23
| base : int | ||
| The generator (base of the exponential). | ||
| target : int | ||
| The target value (target ≡ base^x mod modulus). | ||
| modulus : int |
There was a problem hiding this comment.
Please do not repeat the datatypes (int) from above, because if one is changed and the other is not, then readers become confused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist: