Skip to content

Updated Stack #2414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 13, 2020
Merged

Updated Stack #2414

merged 4 commits into from
Sep 13, 2020

Conversation

realDuYuanChao
Copy link
Member

@realDuYuanChao realDuYuanChao commented Sep 10, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

realDuYuanChao and others added 2 commits September 11, 2020 00:25
@realDuYuanChao
* Added type hints
8a8dca5 
* Added test
* Formated code
updating DIRECTORY.md
f7d98be
@realDuYuanChao
Copy link
Member Author

@cclauss Please review. Thanks :)

cclauss
cclauss reviewed Sep 10, 2020
View reviewed changes
data_structures/stacks/stack.py Outdated
Comment on lines 29 to 30
if self.is_empty():
raise IndexError("pop from an empty stack")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it do exactly the same thing if you remove lines 29 and 30?

cclauss
cclauss reviewed Sep 10, 2020
View reviewed changes
data_structures/stacks/stack.py Outdated
Comment on lines 35 to 36
if self.is_empty():
raise IndexError("peek from an empty stack")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it do a similar thing if you remove lines 35 and 36?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line3 35 and 36 execute when stack is empty. assert() statements will still be successful if i remove them .

@TheAlgorithms TheAlgorithms deleted a comment from StarGuard0 Sep 12, 2020
@realDuYuanChao
Copy link
Member Author

Need I update @cclauss ？

@realDuYuanChao
Copy link
Member Author

Thanks @cclauss . Nice updates. LGTM 👍

@cclauss cclauss merged commit 44b8cb0 into TheAlgorithms:master Sep 13, 2020
@realDuYuanChao realDuYuanChao deleted the dev branch September 14, 2020 17:15
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@realDuYuanChao @cclauss @stokhos
Updated Stack (TheAlgorithms#2414)
74f4494 
* * Added type hints
* Added test
* Formated code

* updating DIRECTORY.md

* Update stack.py

* Test error conditions for pop, peek, and

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@swapnanildutta swapnanildutta swapnanildutta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@realDuYuanChao @cclauss @swapnanildutta