Skip to content

recaptchaVerification #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Sep 13, 2020
Merged

recaptchaVerification #2417

merged 19 commits into from
Sep 13, 2020

Conversation

santoshrajkumar
Copy link
Contributor

@santoshrajkumar santoshrajkumar commented Sep 12, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@TravisBuddy
Copy link

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 86a95150-f4b6-11ea-aaf4-7d25d946cae2

@cclauss
Copy link
Member

cclauss commented Sep 12, 2020 •
edited
Loading

Cool submission! The Travis tests are failing so please see CONTRIBUTING.md discussion of black and flake8 and variable naming.

https://travis-ci.com/github/TheAlgorithms/Python/builds/184017264

@santoshrajkumar
Copy link
Contributor Author

Cool submission! The Travis tests are failing so please see CONTRIBUTING.md discussion of black and flake8 and variable naming.

https://travis-ci.com/github/TheAlgorithms/Python/builds/184017264

Shall look into it. Being part of na back end code, there may be issues coming up.

@TravisBuddy
Copy link

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 0692f490-f4ba-11ea-aaf4-7d25d946cae2

@cclauss
Copy link
Member

cclauss commented Sep 12, 2020 •
edited
Loading

https://travis-ci.com/github/TheAlgorithms/Python/builds/184018231#L294-L307

Most of these can be autofixed by running black on your code.

@santoshrajkumar
Copy link
Contributor Author

santoshrajkumar commented Sep 12, 2020 •
edited
Loading

https://travis-ci.com/github/TheAlgorithms/Python/builds/184018231#L294-L307

Most of these can be autofixed by running black on your code.

Ran black on the code & repushed.

@TravisBuddy
Copy link

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 14851ba0-f4bf-11ea-aaf4-7d25d946cae2

@TravisBuddy
Copy link

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 17b56210-f4c1-11ea-aaf4-7d25d946cae2

santoshrajkumar
santoshrajkumar commented Sep 12, 2020
View reviewed changes
Copy link
Contributor Author

@santoshrajkumar santoshrajkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried to resolve in the latest commit

@TravisBuddy
Copy link

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: a756f1e0-f4c1-11ea-aaf4-7d25d946cae2

cclauss
cclauss reviewed Sep 12, 2020
View reviewed changes
web_programming/recaptcha_verification.py Outdated
verify = response["success"]

# if verify is true
if verify == True:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See PEP8...

Suggested change
if verify == True:
if verify:

cclauss
cclauss reviewed Sep 12, 2020
View reviewed changes
web_programming/recaptcha_verification.py Outdated
return render(request, "login.html")
else:
# if verify is not true, send user back to login page
return render(request, "login.html")
Copy link
Member

@cclauss cclauss Sep 12, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return render(request, "login.html")
return render(request, "login.html")

That ⛔ sign is because the GitHub editor knows that Python files end with one and only one \n.

@TravisBuddy
Copy link

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 14c57140-f4c5-11ea-aaf4-7d25d946cae2

@TravisBuddy
Copy link

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 9ffc7e30-f4c9-11ea-aaf4-7d25d946cae2

@TravisBuddy
Copy link

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 30234390-f4ca-11ea-aaf4-7d25d946cae2

@TravisBuddy
Copy link

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: a75eeab0-f4cd-11ea-aaf4-7d25d946cae2

@TravisBuddy
Copy link

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: e090f210-f4cd-11ea-aaf4-7d25d946cae2

cclauss
cclauss requested changes Sep 12, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please get Travis to be green...
https://github.com/TheAlgorithms/Python/blob/master/Travis_CI_tests_are_failing.md

@TravisBuddy
Copy link

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 28fe7b50-f4d1-11ea-aaf4-7d25d946cae2

@TravisBuddy
Copy link

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: d8d4fa40-f4d1-11ea-aaf4-7d25d946cae2

@TravisBuddy
Copy link

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: e4e2f4d0-f4d2-11ea-aaf4-7d25d946cae2

@TravisBuddy
Copy link

Travis tests have failed

Hey @santoshrajkumar,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 114378a0-f4d4-11ea-aaf4-7d25d946cae2

@TravisBuddy
Copy link

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: e0251740-f4d5-11ea-aaf4-7d25d946cae2

@santoshrajkumar
Copy link
Contributor Author

santoshrajkumar commented Sep 12, 2020 •
edited
Loading

Please get Travis to be green...
https://github.com/TheAlgorithms/Python/blob/master/Travis_CI_tests_are_failing.md

Travis tests have been passed, modified bit to make it pass.

santoshrajkumar
santoshrajkumar commented Sep 13, 2020
View reviewed changes
Copy link
Contributor Author

@santoshrajkumar santoshrajkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems nicer now !

@santoshrajkumar
Copy link
Contributor Author

May be merged if you'd like to.

@cclauss cclauss merged commit 4e5b730 into TheAlgorithms:master Sep 13, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@santoshrajkumar @cclauss @stokhos
recaptchaVerification (TheAlgorithms#2417)
f1a0227 
* recaptchaVerification

* recaptchaVerification

* recaptchaVerification1

* recaptchaVerification2

* recaptchaVerification3

* recaptchaVerification4

* recaptchaVerificatio5

* recaptchaVerificatio5

* recaptchaVerificatio6

* drawOnVideoStreamOpenCV

* matrixInverseMCAmethod

* fixingImports

* recaptchaVerificationfixes

* recaptchaVerificationfixes

* recaptchaVerificationfixes

* recaptchaVerificationfixes

* recaptchaVerificationfixes1

* recaptchaVerificationfixes1

* authenticate = login = render = redirect = print

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@santoshrajkumar @TravisBuddy @cclauss