Skip to content

[mypy] Fix web_programming directory #4297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Mar 31, 2021
Merged

[mypy] Fix web_programming directory #4297

merged 34 commits into from
Mar 31, 2021

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Mar 28, 2021 •
edited
Loading

A subtask of #4052

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

cclauss and others added 22 commits March 28, 2021 03:57
@cclauss
Experiment: monkeytype stub web_programming
2428a10
@cclauss
pytest --doctest-modules web_programming
1ef01e7
@cclauss
world_covid19_stats.py
aaea821
@cclauss
monkeytype stub web_programming.world_covid19_stats
6b96969
@cclauss
Create monkeytype_config.py
2220b88
updating DIRECTORY.md
484855c
@cclauss
monkeytype run pytest --doctest-modules
6570772
@cclauss
monkeytype run python3 -m pytest --doctest-modules
73712f1
@cclauss
Update monkeytype.yml
bb8909f
@cclauss
/opt/hostedtoolcache/Python/3.9.2/x64/bin/python3/opt/hostedtoolcache…
5480ec4 
…/Python/3.9.2/x64/bin/python3/opt/hostedtoolcache/Python/3.9.2/x64/bin/python3
@cclauss
Update monkeytype.yml
ccf7acf
@cclauss
Update monkeytype.yml
2df9939
@cclauss
monkeytype run web_programming/*.py
5ed45b3
@cclauss
monkeytype list-modules
7ab64b3
@cclauss
Update monkeytype.yml
b532d22
@cclauss
Update monkeytype.yml
7a14b85
@cclauss
Update monkeytype.yml
7090302
@cclauss
pyannotate
dcd5109
@cclauss
from pyannotate_runtime import collect_types
560de38
@cclauss
typing: API_KEY is a str
3546524
@cclauss
pyannotate emails_from_url.py
da9ec61
@cclauss
pyannotate web_programming/emails_from_url.py
8cc34cd
@github-actions github-actions bot force-pushed the monkeytype-stub-web_programming branch from 78cf514 to 8cc34cd Compare March 28, 2021 12:03
@cclauss cclauss requested a review from dhruvmanila March 28, 2021 12:51
@cclauss cclauss changed the title Experiment: monkeytype stub web_programming mypy: Fix web_programming directory Mar 28, 2021
@cclauss cclauss marked this pull request as ready for review March 28, 2021 12:52
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Mar 28, 2021
@cclauss
Copy link
Member Author

cclauss commented Mar 28, 2021 •
edited
Loading

Please Squash & merge to get rid of experimental commits.

I tried to use MonkeyType but it is impossible!! PyAnnotate is the way to go.

@cclauss cclauss changed the title mypy: Fix web_programming directory [mypy] Fix web_programming directory Mar 28, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Mar 31, 2021
@dhruvmanila dhruvmanila merged commit 895bca3 into master Mar 31, 2021
@cclauss cclauss deleted the monkeytype-stub-web_programming branch March 31, 2021 05:21
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@cclauss @dhruvmanila @peRFectBeliever
[mypy] Fix web_programming directory (TheAlgorithms#4297)
700820e 
* Update world_covid19_stats.py

* Delete monkeytype_config.py

* updating DIRECTORY.md

* Apply pyannotate suggestions to emails_from_url.py

* mypy web_programming/emails_from_url.py

* super().__init__()

* mypy --ignore-missing-imports web_programming/emails_from_url.py

* Update emails_from_url.py

* self.urls: list[str] = []

* mypy: Fix web_programming directory

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@cclauss @dhruvmanila
[mypy] Fix web_programming directory (TheAlgorithms#4297)
cd81f1b 
* Update world_covid19_stats.py

* Delete monkeytype_config.py

* updating DIRECTORY.md

* Apply pyannotate suggestions to emails_from_url.py

* mypy web_programming/emails_from_url.py

* super().__init__()

* mypy --ignore-missing-imports web_programming/emails_from_url.py

* Update emails_from_url.py

* self.urls: list[str] = []

* mypy: Fix web_programming directory

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@cclauss @dhruvmanila @shermanhui
[mypy] Fix web_programming directory (TheAlgorithms#4297)
ae9b5e3 
* Update world_covid19_stats.py

* Delete monkeytype_config.py

* updating DIRECTORY.md

* Apply pyannotate suggestions to emails_from_url.py

* mypy web_programming/emails_from_url.py

* super().__init__()

* mypy --ignore-missing-imports web_programming/emails_from_url.py

* Update emails_from_url.py

* self.urls: list[str] = []

* mypy: Fix web_programming directory

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @dhruvmanila