-
-
Notifications
You must be signed in to change notification settings - Fork 46.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LGTM: Start testing on Python 3 instead of Python 2 #510
Conversation
@cclauss All checks failed! The LGTM extraction log says from __future__ import print_function but did not bothered to write: try:
raw_input # Python 2
except NameError:
raw_input = input # Python 3 |
i’ll change the .lgtm.yml in #500 so that all tests will pass then this can be closed or merged |
@harshildarji Yes... Those issues were created in one merged pull request. https://github.com/TheAlgorithms/Python/pull/483/files @AlexDvorak is busy fixing them in #500 |
@cclauss I can revert the PR #483! But as you said @AlexDvorak is working on it, I won't revert it, otherwise it may cause conflicts (I think). |
so is this PR going to get merged as #500 is already merged? |
We need #486 to land first. Also a raw_int fix. |
@cclauss I've corrected raw_int and also that get_ipython thing! So I think this time there will be no errors! |
Fixes: #492
Tests for the issues raised in #485, #486, and #500
Ready for review. @harshildarji @ParthS007 @AlexDvorak