Skip to content

sock_merchant.py: Matching socks by color #5761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Nov 3, 2021
Merged

sock_merchant.py: Matching socks by color #5761

merged 21 commits into from
Nov 3, 2021

Conversation

SouvikGhosh05
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Happy to contribute in the repo.
If there's any issue arises, kindly let me know.
Thanks!

@ghost ghost added awaiting reviews This PR is ready to be reviewed require descriptive names This PR needs descriptive function and/or variable names labels Nov 3, 2021
ghost
ghost reviewed Nov 3, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost
ghost reviewed Nov 3, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

maths/iterative_pair.py Outdated
from collections import Counter


def sock_merchant(n: int, ar: list[int]) -> int:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide descriptive name for the parameter: n

@ghost ghost removed the require descriptive names This PR needs descriptive function and/or variable names label Nov 3, 2021
@SouvikGhosh05
Copy link
Contributor Author

@l3str4nge @cclauss kindly review it. For any issues, let me know. Thanks!

@cclauss
Copy link
Member

cclauss commented Nov 3, 2021

Please add a URL to a description of what this algorithm is and why solving is useful.

@ghost ghost added the tests are failing Do not merge until tests pass label Nov 3, 2021
@cclauss cclauss changed the title Added python file for iterative count of pairs sock_merchant.py: Matching socks by color Nov 3, 2021
@SouvikGhosh05
Copy link
Contributor Author

SouvikGhosh05 commented Nov 3, 2021 •
edited
Loading

What may be the cause of build failure? @cclauss

@SouvikGhosh05
Copy link
Contributor Author

I fixed it, probably it should now work properly. @cclauss

@SouvikGhosh05
Copy link
Contributor Author

The error is not from my code

ERROR computer_vision/cnn_classification.py - tensorflow.python.framework.err...
ERROR machine_learning/lstm/lstm_prediction.py - tensorflow.python.framework....
!!!!!!!!!!!!!!!!!!! Interrupted: 2 errors during collection !!!!!!!!!!!!!!!!!!!!
======================== 1 warning, 2 errors in 21.79s =========================
Error: Process completed with exit code 2```

@cclauss
Copy link
Member

cclauss commented Nov 3, 2021

#5762

cclauss
cclauss reviewed Nov 3, 2021
View reviewed changes
digital_image_processing/edge_detection/canny.py Outdated
@@ -1,6 +1,5 @@
import cv2
import numpy as np

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isort will want to see this blank line between internal and external imports.

@ghost ghost removed the tests are failing Do not merge until tests pass label Nov 3, 2021
@SouvikGhosh05
Copy link
Contributor Author

@cclauss I tried my best to fix the build. Now, you can review.

@ghost ghost added the tests are failing Do not merge until tests pass label Nov 3, 2021
cclauss
cclauss approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost removed awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Nov 3, 2021
@cclauss cclauss merged commit 0ea5c73 into TheAlgorithms:master Nov 3, 2021
@cclauss cclauss mentioned this pull request Nov 3, 2021
Closed
14 tasks
SouvikGhosh05
SouvikGhosh05 commented Nov 4, 2021
View reviewed changes
DIRECTORY.md
@@ -63,7 +64,7 @@
* [Baconian Cipher](https://github.com/TheAlgorithms/Python/blob/master/ciphers/baconian_cipher.py)
* [Base16](https://github.com/TheAlgorithms/Python/blob/master/ciphers/base16.py)
* [Base32](https://github.com/TheAlgorithms/Python/blob/master/ciphers/base32.py)
* [Base64 Encoding](https://github.com/TheAlgorithms/Python/blob/master/ciphers/base64_encoding.py)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss I think this is the issue here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SouvikGhosh05 @cclauss