-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
[Mypy] fix other/least_recently_used #5814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cclauss
merged 18 commits into
TheAlgorithms:master
from
spazm:mypy-fix-other-least_recently_used
Nov 16, 2021
Merged
[Mypy] fix other/least_recently_used #5814
cclauss
merged 18 commits into
TheAlgorithms:master
from
spazm:mypy-fix-other-least_recently_used
Nov 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ deque.remove() operates by value not index
+ clean-up: rename key_reference to match type.
045f54b
to
ec878d9
Compare
cclauss
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for doing this and thanks for making us mypy compliant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
__init__
an abstract function.Generic[T]
LRUCache
over concrete and mixed types.Previously opened as #5656
Closes: #4052
Before
After
Checklist:
Fixes: #{$ISSUE_NO}
.