Skip to content

Conversation

anirudhlakhotia
Copy link
Contributor

@anirudhlakhotia anirudhlakhotia commented Jan 12, 2022

Fixes #5916

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added documentation This PR modified documentation files awaiting reviews This PR is ready to be reviewed labels Jan 12, 2022
@ghost ghost added the tests are failing Do not merge until tests pass label Jan 30, 2022
@poyea
Copy link
Member

poyea commented Mar 16, 2022

@algorithms-keeper review

Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@poyea poyea merged commit 37200a4 into TheAlgorithms:master Mar 16, 2022
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation This PR modified documentation files tests are failing Do not merge until tests pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update license year to 2022

2 participants