Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bucket_sort.py #6005

Merged
merged 1 commit into from
May 12, 2022
Merged

Update bucket_sort.py #6005

merged 1 commit into from
May 12, 2022

Conversation

eee555
Copy link
Contributor

@eee555 eee555 commented Feb 20, 2022

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Feb 20, 2022
@eee555
Copy link
Contributor Author

eee555 commented Feb 20, 2022

why this algorithm worked before was because of using the "sorted", but was wrong.

@eee555
Copy link
Contributor Author

eee555 commented Apr 15, 2022

This bug is ridiculous and ignoring my pull request is quite incomprehensible

@poyea poyea self-assigned this May 12, 2022
poyea
poyea approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label May 12, 2022
@poyea poyea merged commit bbb88bb into TheAlgorithms:master May 12, 2022
@tianyizheng02 tianyizheng02 mentioned this pull request Aug 18, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

Assignees

@poyea poyea

Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eee555 @poyea