Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Two Regex match algorithm (Recursive & DP) #6321

Merged
merged 12 commits into from
Aug 14, 2023
Merged

Add: Two Regex match algorithm (Recursive & DP) #6321

merged 12 commits into from
Aug 14, 2023

Conversation

itsamirhn
Copy link
Member

Describe your change:

I added two solution for simple regex match algorithm.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@itsamirhn itsamirhn requested a review from Kush1101 as a code owner August 12, 2022 12:48
@ghost ghost added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Aug 12, 2022
@ghost ghost removed the tests are failing Do not merge until tests pass label Aug 12, 2022
@stale
Copy link

stale bot commented Sep 21, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Sep 21, 2022
@itsamirhn
Copy link
Member Author

Would anyone review this PR?

tianyizheng02
tianyizheng02 requested changes Aug 13, 2023
View reviewed changes
@stale stale bot removed stale Used to mark an issue or pull request stale. labels Aug 13, 2023
itsamirhn and others added 2 commits August 14, 2023 08:07
@itsamirhn @tianyizheng02
Update dynamic_programming/regex_match.py
c2bd6bf 
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@itsamirhn @tianyizheng02
Update dynamic_programming/regex_match.py
7271e3d 
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Aug 14, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Aug 14, 2023
tianyizheng02
tianyizheng02 requested changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last minor change, but other than that LGTM

itsamirhn and others added 2 commits August 14, 2023 09:02
@itsamirhn @tianyizheng02
Update dynamic_programming/regex_match.py
8c5aef0 
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
475b5b5 
for more information, see https://pre-commit.ci
tianyizheng02
tianyizheng02 approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@tianyizheng02 tianyizheng02 merged commit f24ab2c into TheAlgorithms:master Aug 14, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Aug 14, 2023
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@itsamirhn @tianyizheng02
@pre-commit-ci @sedatguzelsemme
Add: Two Regex match algorithm (Recursive & DP) (TheAlgorithms#6321)
24ea996 
* Add recursive solution to regex_match.py

* Add dp solution to regex_match.py

* Add link to regex_match.py

* Minor edit

* Minor change

* Minor change

* Update dynamic_programming/regex_match.py

Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>

* Update dynamic_programming/regex_match.py

Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>

* Fix ruff formatting in if statements

* Update dynamic_programming/regex_match.py

Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itsamirhn @tianyizheng02