Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Continued fractions #6846

Merged
merged 6 commits into from
Aug 16, 2023
Merged

Added Continued fractions #6846

merged 6 commits into from
Aug 16, 2023

Conversation

Saksham1970
Copy link
Contributor

Describe your change:

added a function to convert a rational number to continued fraction list

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Saksham1970 Saksham1970 requested a review from Kush1101 as a code owner October 8, 2022 20:48
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 8, 2022
@algorithms-keeper algorithms-keeper bot mentioned this pull request Oct 8, 2022
Closed
14 tasks
CaedenPH
CaedenPH reviewed Oct 30, 2022
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss Looks good -
Small changes

@Saksham1970 @CaedenPH
Update maths/continued_fraction.py
e18b2fe 
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
@github-actions github-actions bot force-pushed the continuous-fractions branch from 504a0fd to e18b2fe Compare October 30, 2022 20:14
tianyizheng02 and others added 2 commits August 16, 2023 00:19
@tianyizheng02 @CaedenPH
Update maths/continued_fraction.py
fd1cbe4 
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
@tianyizheng02
Merge branch 'master' into continuous-fractions
12cbf85
@tianyizheng02 tianyizheng02 merged commit bfed2fb into TheAlgorithms:master Aug 16, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Aug 16, 2023
cclauss
cclauss reviewed Aug 16, 2023
View reviewed changes
maths/continued_fraction.py
>>> continued_fraction(1/Fraction("2.25"))
[0, 2, 4]
>>> continued_fraction(Fraction("415/93"))
[4, 2, 6, 7]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs tests for 0 and for negative numbers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added tests for 0 and negative numbers in #8985

@tianyizheng02 tianyizheng02 mentioned this pull request Aug 18, 2023
Merged
14 tasks
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@Saksham1970 @CaedenPH
@tianyizheng02 @sedatguzelsemme
Added Continued fractions (TheAlgorithms#6846)
34ff18a 
* updating DIRECTORY.md

* added continued fractions

* updating DIRECTORY.md

* Update maths/continued_fraction.py

Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>

* Update maths/continued_fraction.py

Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss left review comments

@CaedenPH CaedenPH CaedenPH left review comments

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Saksham1970 @cclauss @CaedenPH @tianyizheng02