-
-
Notifications
You must be signed in to change notification settings - Fork 46.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch case #7995
Switch case #7995
Conversation
for more information, see https://pre-commit.ci
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper
commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper review
to trigger the checks for only added pull request files@algorithms-keeper review-all
to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really awesome
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New to this could use all the help and support I can get it would be greatly appreciated
deleting remove_digit because it is in the wrong pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper
commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper review
to trigger the checks for only added pull request files@algorithms-keeper review-all
to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
strings/string_switch_case.py
Outdated
""" | ||
|
||
# assistant functions | ||
def split_input(str_: str) -> str: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there is no test file in this pull request nor any test function or class in the file strings/string_switch_case.py
, please provide doctest for the function split_input
return [char.split() for char in re.split(r"[^ a-z A-Z 0-9 \s]", str_)] | ||
|
||
|
||
def to_simple_case(str_: str) -> str: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there is no test file in this pull request nor any test function or class in the file strings/string_switch_case.py
, please provide doctest for the function to_simple_case
) | ||
|
||
|
||
def to_complex_case(text: str, upper: bool, separator: str) -> str: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there is no test file in this pull request nor any test function or class in the file strings/string_switch_case.py
, please provide doctest for the function to_complex_case
following bot reccomendations
@CaedenPH , just fixed some bugs and this pr is ready! :) |
@cclauss , if you have a free minute, could you please check out this pull request? |
Describe your change:
In this repository a similar algorithm exsists. HOWEVER! it "Transforms a snake_case given string to camelCase (or PascalCase if indicated)". The file in this pull request, and these algorithms contain functions which can trasnform a usual string to different cases [ pascal case, camel case, kebab case, snake case ].
Checklist:
Fixes: #{$ISSUE_NO}
.