Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the complexity of other/scoring_algorithm.py #8045

Merged
merged 7 commits into from
Mar 2, 2023
Merged

Reduce the complexity of other/scoring_algorithm.py #8045

merged 7 commits into from
Mar 2, 2023

Conversation

MaximSmolskiy
Copy link
Member

Describe your change:

Reduce the complexity of other/scoring_algorithm.py from 16 to 10

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass labels Dec 24, 2022
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Dec 24, 2022
CaedenPH
CaedenPH reviewed Dec 24, 2022
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I am misunderstanding something, but why is the max complexity being increased?

@MaximSmolskiy
Copy link
Member Author

Maybe I am misunderstanding something, but why is the max complexity being increased?

It was decreased in #7954, but now there are algorithms with greater complexity.

@MaximSmolskiy MaximSmolskiy requested review from CaedenPH and removed request for cclauss and dhruvmanila January 9, 2023 11:41
@MaximSmolskiy
Copy link
Member Author

@cclauss please review

dhruvmanila
dhruvmanila requested changes Mar 1, 2023
View reviewed changes
other/scoring_algorithm.py Outdated
Comment on lines 108 to 113
data_lists: list[list[float]] = get_data(source_data)

score_lists: list[list[float]] = calculate_each_score(data_lists, weights)

final_scores: list[float] = generate_final_scores(score_lists)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
data_lists: list[list[float]] = get_data(source_data)
score_lists: list[list[float]] = calculate_each_score(data_lists, weights)
final_scores: list[float] = generate_final_scores(score_lists)
data_lists = get_data(source_data)
score_lists = calculate_each_score(data_lists, weights)
final_scores = generate_final_scores(score_lists)

There's no need to specify variable type hint as the functions are already annotated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@algorithms-keeper algorithms-keeper bot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Mar 1, 2023
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Mar 1, 2023
@MaximSmolskiy MaximSmolskiy requested review from dhruvmanila and removed request for CaedenPH March 1, 2023 19:27
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Mar 2, 2023
@dhruvmanila dhruvmanila merged commit ee77812 into TheAlgorithms:master Mar 2, 2023
@MaximSmolskiy MaximSmolskiy deleted the reduce-the-complexity-of-other/scoring_algorithm.py branch March 2, 2023 07:01
Cjkjvfnby pushed a commit to Cjkjvfnby/Python that referenced this pull request Mar 13, 2023
@MaximSmolskiy @Cjkjvfnby
Reduce the complexity of other/scoring_algorithm.py (TheAlgorithms#8045)
3b3a16d 
* Increase the --max-complexity threshold in the file .flake8
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Mar 19, 2023
@MaximSmolskiy @sedatguzelsemme
Reduce the complexity of other/scoring_algorithm.py (TheAlgorithms#8045)
6053487 
* Increase the --max-complexity threshold in the file .flake8
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaedenPH CaedenPH CaedenPH left review comments

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaximSmolskiy @CaedenPH @dhruvmanila