Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI badge in the README.md #8132 #8137

Merged
merged 1 commit into from
May 25, 2023
Merged

Fix CI badge in the README.md #8132 #8137

merged 1 commit into from
May 25, 2023

Conversation

ratneshrt
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed documentation This PR modified documentation files labels Feb 12, 2023
CaedenPH
CaedenPH approved these changes Feb 12, 2023
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this url change is correct, but could you show the before and after with screenshots of an md file

@ratneshrt
Copy link
Contributor Author

image

@CaedenPH Yes, here is the scree shot of the before and after the change of the md file.

@CaedenPH
Copy link
Contributor

image

@CaedenPH Yes, here is the scree shot of the before and after the change of the md file.

No, I meant the img that is shown

@ratneshrt
Copy link
Contributor Author

image

![image](https://user-images.githubusercontent.com/89133941/218323669-58634233-4ad2-42c0-98c6-63acf39aeddf.png) Here it is..

@ratneshrt
Copy link
Contributor Author

Previous Image
image

@dhruvmanila
Copy link
Member

I don't see any problem:

Screenshot 2023-04-01 at 17 58 25

@cclauss cclauss mentioned this pull request May 25, 2023
Closed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label May 25, 2023
@cclauss cclauss merged commit a663148 into TheAlgorithms:master May 25, 2023
tianyizheng02 pushed a commit to tianyizheng02/Python that referenced this pull request May 29, 2023
@ratneshrt @tianyizheng02
Fix CI badge in the README.md (TheAlgorithms#8137)
6d128ad
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@CaedenPH CaedenPH CaedenPH approved these changes

Assignees
No one assigned
Labels
documentation This PR modified documentation files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ratneshrt @CaedenPH @dhruvmanila @cclauss