Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bogo_sort.py #8144

Merged
merged 1 commit into from
Feb 19, 2023
Merged

Update bogo_sort.py #8144

merged 1 commit into from
Feb 19, 2023

Conversation

yanvoi
Copy link
Contributor

@yanvoi yanvoi commented Feb 17, 2023

Describe your change:

The if statement I deleted is actually redundant:
if len(collection) is smaller than 2 then the for loop will not execute (range() function starts from 0 by default) and the function will return True.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@yanvoi
Update bogo_sort.py
f0d910b 
The if statement I deleted is actually redundant:
if len(collection) is smaller than 2 then the for loop will not execute (range() function starts from 0 by default) and the function will return True.
@yanvoi
Copy link
Contributor Author

yanvoi commented Feb 17, 2023

It's a very simple change but I couldn't help myself - I'm sorry.

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Feb 17, 2023
CaedenPH
CaedenPH approved these changes Feb 18, 2023
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@ChrisO345 ChrisO345 merged commit 1bf0388 into TheAlgorithms:master Feb 19, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Feb 19, 2023
Cjkjvfnby pushed a commit to Cjkjvfnby/Python that referenced this pull request Mar 13, 2023
@yanvoi @Cjkjvfnby
Update bogo_sort.py (TheAlgorithms#8144)
4554e98
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Mar 19, 2023
@yanvoi @sedatguzelsemme
Update bogo_sort.py (TheAlgorithms#8144)
770b962
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaedenPH CaedenPH CaedenPH approved these changes

@ChrisO345 ChrisO345 ChrisO345 approved these changes

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yanvoi @CaedenPH @ChrisO345 @tianyizheng02