Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the complexity of backtracking/word_search.py #8166

Merged
merged 3 commits into from
Mar 10, 2023
Merged

Reduce the complexity of backtracking/word_search.py #8166

merged 3 commits into from
Mar 10, 2023

Conversation

MaximSmolskiy
Copy link
Member

@MaximSmolskiy MaximSmolskiy commented Mar 4, 2023 •
edited
Loading

Describe your change:

Reduce the complexity of backtracking/word_search.py from 18 to 10

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Mar 4, 2023
dhruvmanila
dhruvmanila requested changes Mar 10, 2023
View reviewed changes
@algorithms-keeper algorithms-keeper bot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Mar 10, 2023
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Mar 10, 2023
@MaximSmolskiy MaximSmolskiy requested review from dhruvmanila and removed request for cclauss March 10, 2023 08:43
@dhruvmanila dhruvmanila merged commit f9cc252 into TheAlgorithms:master Mar 10, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Mar 10, 2023
@MaximSmolskiy MaximSmolskiy deleted the reduce-the-complexity-of-backtracking/word_search.py branch March 10, 2023 09:51
Cjkjvfnby pushed a commit to Cjkjvfnby/Python that referenced this pull request Mar 13, 2023
@MaximSmolskiy @Cjkjvfnby
Reduce the complexity of backtracking/word_search.py (TheAlgorithms#8166
28731e9 
)

* Lower the --max-complexity threshold in the file .flake8
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Mar 19, 2023
@MaximSmolskiy @sedatguzelsemme
Reduce the complexity of backtracking/word_search.py (TheAlgorithms#8166
67cd14d 
)

* Lower the --max-complexity threshold in the file .flake8
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaximSmolskiy @dhruvmanila