Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken links to Gitter community #8546

Merged
merged 2 commits into from
Mar 26, 2023
Merged

Fix broken links to Gitter community #8546

merged 2 commits into from
Mar 26, 2023

Conversation

ChVeen
Copy link
Contributor

@ChVeen ChVeen commented Mar 25, 2023 •
edited
Loading

Describe your change:

The link https://gitter.im/TheAlgorithms as used in the README.md and CONTRIBUTING.md files is invalid and returns the error 404 Not Found.
I fixed the link to the working version https://gitter.im/TheAlgorithms/community.

This PR fixes issue #8197

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed documentation This PR modified documentation files tests are failing Do not merge until tests pass labels Mar 25, 2023
CaedenPH
CaedenPH approved these changes Mar 25, 2023
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot

@ChVeen
Copy link
Contributor Author

ChVeen commented Mar 25, 2023

Hi @CaedenPH, thanks. Unfortunately, ruff produced errors and I did not touch even a single Python file, just markdown files. What to do about this? My master was already synced while branching.

@CaedenPH
Copy link
Contributor

Hi @CaedenPH, thanks. Unfortunately, ruff produced errors and I did not touch even a single Python file, just markdown files. What to do about this? My master was already synced while branching.

Yep not a problem, must be a problem with the workflows

@ChVeen ChVeen mentioned this pull request Mar 26, 2023
Closed
@cclauss cclauss mentioned this pull request Mar 26, 2023
Merged
14 tasks
@ChVeen
Copy link
Contributor Author

ChVeen commented Mar 26, 2023 •
edited
Loading

Dear @cclauss, I solved this issue 17h ago and KaixLina "copied" this 10h ago. Well...

@cclauss cclauss reopened this Mar 26, 2023
@algorithms-keeper algorithms-keeper bot added the merge conflicts Open a new PR or rebase on the latest commit label Mar 26, 2023
@algorithms-keeper algorithms-keeper bot removed the merge conflicts Open a new PR or rebase on the latest commit label Mar 26, 2023
cclauss
cclauss approved these changes Mar 26, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR uses a better URL so I have reopened and I will merge it when all tests pass.

@algorithms-keeper algorithms-keeper bot removed awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Mar 26, 2023
@cclauss cclauss merged commit 86b2ab0 into TheAlgorithms:master Mar 26, 2023
@cclauss
Copy link
Member

cclauss commented Mar 26, 2023

Thanks @ChVeen

tianyizheng02 pushed a commit to tianyizheng02/Python that referenced this pull request May 29, 2023
@ChVeen @cclauss @tianyizheng02
Fix broken links to Gitter Community (Fixes: TheAlgorithms#8197) (The…
9cbe86a 
…Algorithms#8546)

Co-authored-by: Christian Clauss <cclauss@me.com>
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@ChVeen @cclauss @sedatguzelsemme
Fix broken links to Gitter Community (Fixes: TheAlgorithms#8197) (The…
fec6d9f 
…Algorithms#8546)

Co-authored-by: Christian Clauss <cclauss@me.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@CaedenPH CaedenPH CaedenPH approved these changes

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees
No one assigned
Labels
documentation This PR modified documentation files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChVeen @CaedenPH @cclauss