added a problem with solution on sliding window.

[rohan472000]

Describe your change:

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Documentation change?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new Python files are placed inside an existing directory.
• All filenames are in all lowercase characters with no spaces or dashes.
• All functions and variable names follow Python naming conventions.
• All function parameters and return values are annotated with Python type hints.
• All functions have doctests that pass the automated testing.
• All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
• If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

[algorithms-keeper]

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

• Contributing guidelines
• Project Euler solution guidelines

Python:

• Formatted string literals (f-strings)
• Type hints
• doctest
• unittest
• pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

---

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

• @algorithms-keeper review to trigger the checks for only added pull request files
• @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

[algorithms-keeper]

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

• Contributing guidelines
• Project Euler solution guidelines

Python:

• Formatted string literals (f-strings)
• Type hints
• doctest
• unittest
• pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

---

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

• @algorithms-keeper review to trigger the checks for only added pull request files
• @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

[algorithms-keeper]

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py

Traceback (most recent call last):
  File "/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line 145, in parse
    reports = lint_file(
              ^^^^^^^^^^
libcst._exceptions.ParserSyntaxError: Syntax Error @ 23:5.
parser error: error at 22:4: expected one of (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~

    if n == 0:
    ^

[algorithms-keeper]

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

• Contributing guidelines
• Project Euler solution guidelines

Python:

• Formatted string literals (f-strings)
• Type hints
• doctest
• unittest
• pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

---

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

• @algorithms-keeper review to trigger the checks for only added pull request files
• @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

[algorithms-keeper]

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py

Traceback (most recent call last):
  File "/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line 145, in parse
    reports = lint_file(
              ^^^^^^^^^^
libcst._exceptions.ParserSyntaxError: Syntax Error @ 24:5.
parser error: error at 23:4: expected one of (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~

    if(n == 0):
    ^

[algorithms-keeper]

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

• Contributing guidelines
• Project Euler solution guidelines

Python:

• Formatted string literals (f-strings)
• Type hints
• doctest
• unittest
• pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

---

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

• @algorithms-keeper review to trigger the checks for only added pull request files
• @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

[algorithms-keeper]

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py

Traceback (most recent call last):
  File "/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line 145, in parse
    reports = lint_file(
              ^^^^^^^^^^
libcst._exceptions.ParserSyntaxError: Syntax Error @ 20:5.
parser error: error at 19:4: expected one of (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~

    if n == 0:
    ^

[algorithms-keeper]

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

• Contributing guidelines
• Project Euler solution guidelines

Python:

• Formatted string literals (f-strings)
• Type hints
• doctest
• unittest
• pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

---

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

• @algorithms-keeper review to trigger the checks for only added pull request files
• @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

[algorithms-keeper]

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py

Traceback (most recent call last):
  File "/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line 145, in parse
    reports = lint_file(
              ^^^^^^^^^^
libcst._exceptions.ParserSyntaxError: Syntax Error @ 19:5.
parser error: error at 18:4: expected one of (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~

    if n == 0:
    ^

[CaedenPH]

Typically these parameters and return types should be self documented so these are unnecessary

[rohan472000]

Sure...i will remove it

[rohan472000]

Done

[CaedenPH]

Could you add a couple more doctests with different numbers and perhaps negative numbers as well

[rohan472000]

Yeah I will do it sooner

[rohan472000]

@CaedenPH, done....

[tianyizheng02]

It's probably best to place this in an existing directory rather than creating a new directory just for this file

[rohan472000]

@tianyizheng02, well there is no directory for this algo, so i made it where all questions and answers based on sliding window can be kept.

[tianyizheng02]

Algorithms in this repo are placed in directories based on broad categories like dynamic programming, machine learning, sorting algorithms, etc. It's best to place new algorithm files in the same directory as similar algorithms rather than making a whole new directory for a single algorithm.

[rohan472000]

yeah got it....made the changes

[cclauss]

Why this change?

[rohan472000]

now I removed it

[cclauss]

Why can't we have checkboxes like every other pull request has?

[rohan472000]

yeah ...filled the checkboxes

[cclauss]

Markdown has a syntax for checklists... https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/about-task-lists#creating-task-lists

[tianyizheng02]

No, you fill the checkboxes like this:

* [x] Test 1
* [ ] Test 2
* [ ] Test 3

And it should look like this in the preview:

• Test 1
• Test 2
• Test 3

[rohan472000]

No, you fill the checkboxes like this:

* [x] Test 1
* [ ] Test 2
* [ ] Test 3

And it should look like this in the preview:

• Test 1
• Test 2
• Test 3

Thanks....I changed it.

[rohan472000]

@cclauss @tianyizheng02
I'm getting below error, what case can we add to solve these testcases?

Failure

---

File "C:\pycharm\codes\Python-pull\sliding_window\minimum_size_subarray_sum.py", line 20, in minimum_size_subarray_sum.minimum_subarray_sum
Failed example:
minimum_subarray_sum(0, [1, 2, 3])
Expected:
0
Got:
1

Failure

---

File "C:\pycharm\codes\Python-pull\sliding_window\minimum_size_subarray_sum.py", line 32, in minimum_size_subarray_sum.minimum_subarray_sum
Failed example:
minimum_subarray_sum(-6, [3, 4, 5])
Expected:
0
Got:
1

[tianyizheng02]

Returns the length of the shortest contiguous subarray in a list of numbers whose sum is at least target.

So then minimum_subarray_sum(0, [1, 2, 3]) should return 1, not 0 like you wrote, because the shortest contiguous subarray with sum ≥ 0 is [1].

Likewise, minimum_subarray_sum(-6, [3, 4, 5]) should return 1, not 0 like you wrote, because the shortest contiguous subarray with sum ≥ -6 is [3].

In short, the code isn't wrong; it's those two tests that are wrong. Adding more test cases won't fix the issue.

[rohan472000]

done...i was thinking to do that earlier...

[rohan472000]

@cclauss @tianyizheng02 @CaedenPH , please review the code.

[rohan472000]

@cclauss ,It has been more than 2 weeks of this PR, review it, if something has to be changed in it then suggest.

[cclauss]

The one thing that I forgot to ask for is a URL to a Wikipedia article or some other source that explains the algorithm and where/when it should be used. Reading the code, I did not understand that this was related to sliding window, A URL to more details can be a great help to visitors to our repo. If you add a URL to the docstring then I will gladly re-review.