Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docstring in present_value.py #8702

Merged
merged 2 commits into from
May 1, 2023
Merged

Fix docstring in present_value.py #8702

merged 2 commits into from
May 1, 2023

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Apr 30, 2023

@dhruvmanila Please review this mistake that I made.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

cclauss and others added 2 commits April 30, 2023 19:36
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Apr 30, 2023
@cclauss cclauss requested a review from dhruvmanila April 30, 2023 17:37
@cclauss cclauss enabled auto-merge (squash) April 30, 2023 17:37
@dhruvmanila dhruvmanila disabled auto-merge May 1, 2023 00:58
@dhruvmanila dhruvmanila merged commit f6df26b into master May 1, 2023
@dhruvmanila dhruvmanila deleted the Fix-docstring-in-present_value.py branch May 1, 2023 01:00
tianyizheng02 pushed a commit to tianyizheng02/Python that referenced this pull request May 29, 2023
@cclauss @tianyizheng02
Fix docstring in present_value.py (TheAlgorithms#8702)
1069240 
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@cclauss @sedatguzelsemme
Fix docstring in present_value.py (TheAlgorithms#8702)
227d6c1 
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

@amirsoroush amirsoroush amirsoroush approved these changes

Assignees

@dhruvmanila dhruvmanila

Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cclauss @dhruvmanila @amirsoroush