Added Coulomb_Law #8714

gudlu1925 · 2023-05-07T08:35:59Z

Describe your change:

I have added a Coulomb law python code under physics to calculate force between two charges.

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

for more information, see https://pre-commit.ci

rohan472000 · 2023-05-07T14:30:18Z

physics/coulomb_law.py

@@ -0,0 +1,63 @@
+"""
+Description : The law states that the magnitude of the electrostatic force of attraction or repulsion between two point charges is directly proportional


use ruff . then ruff . --fix to fix ruff and pre-commit issues

tianyizheng02

I feel that the header docstring is too verbose and some parts, such as the paragraph about Coulomb discovering the formula, are either a bit repetitive or not particularly important to include. Instead of directly quoting the cited article for most of the documentation, consider briefly summarizing what the formula calculates and discussing the intuition behind it

tianyizheng02 · 2023-05-09T05:46:13Z

physics/coulomb_law.py

Consider changing the file name from coulomb_law.py to coulombs_law.py, since the name is "Coulomb's Law"

tianyizheng02 · 2023-05-09T05:49:45Z

physics/coulomb_law.py

+Charles-Augustin de Coulomb, a French physicist in 1784, measured the force between two point charges and he came up with
+the theory that the force is inversely proportional to the square of the distance between the charges.
+He also found that this force is directly proportional to the product of charges (magnitudes only).


Suggested change

Charles-Augustin de Coulomb, a French physicist in 1784, measured the force between two point charges and he came up with

the theory that the force is inversely proportional to the square of the distance between the charges.

He also found that this force is directly proportional to the product of charges (magnitudes only).

The history of the formula isn't particularly important to understanding the formula itself, imo

tianyizheng02 · 2023-05-09T05:51:22Z

physics/coulomb_law.py

+
+def coulombs_law(q1: float, q2: float, radius: float) -> float:
+    """
+    The Electrostatic Force formula is given as: (k*q1*q2)/(r**2)


Specifying the units of q1, q2, radius, and the output would be helpful

tianyizheng02 · 2023-05-09T05:55:18Z

physics/coulomb_law.py

+Where, F is the Electrostatic force,q1 q2 are the intensity of two charges respecticvely ,
+r is the radius and k is coulombs constant and its value is 9×10^9 N⋅m^2⋅C^−2 .


Suggested change

Where, F is the Electrostatic force,q1 q2 are the intensity of two charges respecticvely ,

r is the radius and k is coulombs constant and its value is 9×10^9 N⋅m^2⋅C^−2 .

where F is the electrostatic force, q1 and q2 are the magnitudes of the two charges respectively,

r is the radius and k = 9×10^9 N⋅m^2/C^2 is Coulomb's constant.

tianyizheng02 · 2023-05-09T05:59:20Z

physics/coulomb_law.py

+
+where k is proportionality constant and equals to 1/4πε0.
+
+Here, ε0 is the epsilon naught and it signifies permittivity of a vacuum. The value of k comes 9 × 10^9 Nm^2/ C^2


9 x 10^9 N * m^2 / C^2 is only an approximation for Coulomb's constant. Wikipedia gives a much more precise value of 8.9875517923 x 10^9 N * m^2 / C^2

tianyizheng02 · 2023-05-09T06:01:20Z

physics/coulomb_law.py

+
+    if radius <= 0:
+        raise ValueError("The radius is always a positive non zero integer")
+    return ((9 * 10**9) * q1 * q2) / (radius**2)


Suggested change

return ((9 * 10**9) * q1 * q2) / (radius**2)

k = 8.9875517923 * 10**9

return (k * q1 * q2) / (radius**2)

Updated code with more precise value of Coulomb's constant

for more information, see https://pre-commit.ci

rohan472000 · 2023-05-09T09:29:57Z

physics/coulombs_law.py

@@ -0,0 +1,37 @@
+"""
+The law states that the magnitude of the electrostatic force of attraction or repulsion between two point charges


Line no.2,3,5 should be break into multiple as it is long ....use 'ruff . --fix'

tianyizheng02 · 2023-05-09T09:29:47Z

physics/coulombs_law.py

@@ -0,0 +1,37 @@
+"""
+The law states that the magnitude of the electrostatic force of attraction or repulsion between two point charges


Suggested change

The law states that the magnitude of the electrostatic force of attraction or repulsion between two point charges

Coulomb's law states that the magnitude of the electrostatic force of attraction or repulsion between two point charges

For clarity

tianyizheng02 · 2023-05-09T09:30:21Z

physics/coulombs_law.py

+
+Coulomb studied the repulsive force between bodies having electrical charges of the same sign.
+
+F  = k*q1*q2/ r^2


Suggested change

F = k*q1*q2/ r^2

F = k*q1*q2/r^2

Spacing

tianyizheng02 · 2023-05-09T09:36:59Z

physics/coulombs_law.py

+
+F  = k*q1*q2/ r^2
+
+k is proportionality constant and equals 1/4πε0.


Suggested change

k is proportionality constant and equals 1/4πε0.

k is the Coulomb constant and equals 1/(4π * ε0).

According to Wikipedia, $k$ is called the Coulomb constant

Added parentheses for clarity, because otherwise it looks like $\frac{1}{4} \pi \varepsilon_0$ and not $\frac{1}{4 \pi \varepsilon_0}$

ChrisO345 · 2023-05-12T02:32:09Z

physics/coulombs_law.py

+F = k*q1*q2/r^2
+
+k is Coulomb's constant and equals 1/(4π*ε0).
+q1 is charge of first body (C)
+q2 is charge of second body (C)
+r is distance between two charged bodies (m)
+"""
+
+
+def coulombs_law(q1: float, q2: float, radius: float) -> float:
+    """


Suggested change

F = k*q1*q2/r^2

k is Coulomb's constant and equals 1/(4π*ε0).

q1 is charge of first body (C)

q2 is charge of second body (C)

r is distance between two charged bodies (m)

"""

def coulombs_law(q1: float, q2: float, radius: float) -> float:

"""

F = k*q1*q2/r^2

k is Coulomb's constant and equals = 1/(4π*ε0).

"""

def coulombs_law(q1: float, q2: float, radius: float) -> float:

"""

:param float q1: charge of first body (C)

:param float q2: charge of second body (C)

:param float r: distance between the two bodies

for more information, see https://pre-commit.ci

gudlu1925 · 2023-05-12T11:24:49Z

Will you please guide me with ruff checking?
I have done ruff. and ruff. --fix is working fine in my system but still the same error is showing in here.

stale · 2023-06-18T13:57:48Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

tianyizheng02 · 2023-05-10T04:10:53Z

physics/coulombs_law.py

@@ -0,0 +1,37 @@
+"""
+Coulombs law states that the magnitude of the electrostatic force of attraction or repulsion between two point charges


Suggested change

Coulombs law states that the magnitude of the electrostatic force of attraction or repulsion between two point charges

Coulomb's law states that the magnitude of the electrostatic force of attraction or repulsion between two point charges

Small grammar fix. Other than that, it looks good to go 👍

* Create coulomb_law.py * Update coulomb_law.py * Update coulomb_law.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update and rename coulomb_law.py to coulombs_law.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update coulombs_law.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update coulombs_law.py * Update coulombs_law.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update coulombs_law.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update coulombs_law.py --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>

gudlu1925 and others added 4 commits May 7, 2023 13:56

Create coulomb_law.py

770e2f4

Update coulomb_law.py

8466f25

Update coulomb_law.py

07f24ca

[pre-commit.ci] auto fixes from pre-commit.com hooks

112b1f9

for more information, see https://pre-commit.ci

algorithms-keeper bot added the tests are failing Do not merge until tests pass label May 7, 2023

rohan472000 suggested changes May 7, 2023

View reviewed changes

tianyizheng02 requested changes May 9, 2023

View reviewed changes

gudlu1925 and others added 3 commits May 9, 2023 14:25

Update and rename coulomb_law.py to coulombs_law.py

fdd4eff

[pre-commit.ci] auto fixes from pre-commit.com hooks

43bd954

for more information, see https://pre-commit.ci

Update coulombs_law.py

2387620

algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label May 9, 2023

[pre-commit.ci] auto fixes from pre-commit.com hooks

d7d6517

for more information, see https://pre-commit.ci

rohan472000 suggested changes May 9, 2023

View reviewed changes

tianyizheng02 requested changes May 9, 2023

View reviewed changes

Update coulombs_law.py

64fceb5

ChrisO345 reviewed May 12, 2023

View reviewed changes

gudlu1925 and others added 4 commits May 12, 2023 16:28

Update coulombs_law.py

c78a384

[pre-commit.ci] auto fixes from pre-commit.com hooks

ce65ffb

for more information, see https://pre-commit.ci

Update coulombs_law.py

1a32040

[pre-commit.ci] auto fixes from pre-commit.com hooks

ed46580

for more information, see https://pre-commit.ci

stale bot added the stale Used to mark an issue or pull request stale. label Jun 18, 2023

tianyizheng02 reviewed Aug 14, 2023

View reviewed changes

stale bot removed stale Used to mark an issue or pull request stale. labels Aug 14, 2023

Update coulombs_law.py

a8bd7cc

algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Sep 27, 2023

tianyizheng02 approved these changes Sep 27, 2023

View reviewed changes

tianyizheng02 merged commit eace4ce into TheAlgorithms:master Sep 27, 2023

algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Sep 27, 2023

isidroas mentioned this pull request Jan 25, 2025

dh isidroas/Python#1

Closed

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Coulomb_Law #8714

Added Coulomb_Law #8714

gudlu1925 commented May 7, 2023 •

edited

Loading

rohan472000 May 7, 2023

tianyizheng02 left a comment

tianyizheng02 May 9, 2023

tianyizheng02 May 9, 2023

tianyizheng02 May 9, 2023

tianyizheng02 May 9, 2023

tianyizheng02 May 9, 2023

tianyizheng02 May 9, 2023

rohan472000 May 9, 2023

tianyizheng02 May 9, 2023

tianyizheng02 May 9, 2023

tianyizheng02 May 9, 2023

ChrisO345 May 12, 2023

gudlu1925 commented May 12, 2023

stale bot commented Jun 18, 2023

tianyizheng02 May 10, 2023

		@@ -0,0 +1,63 @@
		"""
		Description : The law states that the magnitude of the electrostatic force of attraction or repulsion between two point charges is directly proportional

	Charles-Augustin de Coulomb, a French physicist in 1784, measured the force between two point charges and he came up with
	the theory that the force is inversely proportional to the square of the distance between the charges.
	He also found that this force is directly proportional to the product of charges (magnitudes only).

		Where, F is the Electrostatic force,q1 q2 are the intensity of two charges respecticvely ,
		r is the radius and k is coulombs constant and its value is 9×10^9 N⋅m^2⋅C^−2 .


		where k is proportionality constant and equals to 1/4πε0.

		Here, ε0 is the epsilon naught and it signifies permittivity of a vacuum. The value of k comes 9 × 10^9 Nm^2/ C^2

	return ((9 * 10*9) q1 * q2) / (radius**2)
	k = 8.9875517923 * 10**9
	return (k * q1 * q2) / (radius**2)

		@@ -0,0 +1,37 @@
		"""
		The law states that the magnitude of the electrostatic force of attraction or repulsion between two point charges

	The law states that the magnitude of the electrostatic force of attraction or repulsion between two point charges
	Coulomb's law states that the magnitude of the electrostatic force of attraction or repulsion between two point charges


		Coulomb studied the repulsive force between bodies having electrical charges of the same sign.

		F = kq1q2/ r^2


		F = kq1q2/ r^2

		k is proportionality constant and equals 1/4πε0.

	k is proportionality constant and equals 1/4πε0.
	k is the Coulomb constant and equals 1/(4π * ε0).

		@@ -0,0 +1,37 @@
		"""
		Coulombs law states that the magnitude of the electrostatic force of attraction or repulsion between two point charges

Added Coulomb_Law #8714

Added Coulomb_Law #8714

Conversation

gudlu1925 commented May 7, 2023 • edited Loading

Describe your change:

Checklist:

Choose a reason for hiding this comment

tianyizheng02 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gudlu1925 commented May 12, 2023

stale bot commented Jun 18, 2023

Choose a reason for hiding this comment

gudlu1925 commented May 7, 2023 •

edited

Loading