Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty input case in Segment Tree build process #8718

Merged
merged 4 commits into from
Jul 31, 2023

Conversation

roger-sato
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label May 9, 2023
Copy link
Contributor

@rohan472000 rohan472000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To resolve this issue, you need to modify the type annotations, Instead of the current syntax, you should use the X | Y syntax.

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label May 17, 2023
@roger-sato
Copy link
Contributor Author

Thank you for your advice. However, that part wasn't contributed by me, so I'm unsure if I can make corrections to it. I've recently updated my branch following the merge of a PR that made changes to ruff, but it seems like it's failed somewhere else again.

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label May 25, 2023
@roger-sato
Copy link
Contributor Author

@rohan472000
After updating my branch to the latest version, the previous errors have been cleared up. Could you please review my code again? thank you!

Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests all good

@umairefiroz
Copy link

umairefiroz commented May 27, 2023 via email

Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this file is in desperate need of type hints and unit tests (leaving for future work)

@tianyizheng02 tianyizheng02 merged commit 0b0214c into TheAlgorithms:master Jul 31, 2023
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@isidroas isidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants