Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #8715 Update the remove func of binary search tree. #8719

Closed
wants to merge 2 commits into from
Closed

Fix #8715 Update the remove func of binary search tree. #8719

wants to merge 2 commits into from

Conversation

yabea
Copy link

@yabea yabea commented May 9, 2023

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label May 9, 2023
rohan472000
rohan472000 suggested changes May 12, 2023
View reviewed changes
Copy link
Contributor

@rohan472000 rohan472000 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To resolve ruff issue, you need to modify the type annotations in lines 8 and 9. Instead of the current syntax, you should use the X | Y syntax.

@rohan472000
Copy link
Contributor

Actually this error has been seen in a couple of PRs, even when there is no code written in that context, @cclauss plz look into it.

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label May 12, 2023
@yabea
Copy link
Author

yabea commented May 12, 2023

@rohan472000 I've fixed ruff error, but in fact, I also error when I pre-commit locally, maybe someone needs to check it out

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label May 12, 2023
@stale
Copy link

stale bot commented Jun 18, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Jun 18, 2023
@tianyizheng02
Copy link
Contributor

@cclauss This should be closed now that #8752 has been merged and the issue has been fixed

@stale stale bot removed the stale Used to mark an issue or pull request stale. label Jun 20, 2023
@cclauss cclauss closed this Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohan472000 rohan472000 rohan472000 requested changes

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yabea @rohan472000 @tianyizheng02 @cclauss