Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo graphs/greedy_best_first.py #8766

Merged
merged 1 commit into from
May 25, 2023

Conversation

JadeKim042386
Copy link
Contributor

@JadeKim042386 JadeKim042386 commented May 25, 2023

Fixes #8764

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels May 25, 2023
@JadeKim042386
Copy link
Contributor Author

JadeKim042386 commented May 25, 2023

@cclauss @tianyizheng02 For subsequent contributions and fix failing build tests, #8763 must be reflected.

FAILED web_programming/fetch_anime_and_play.py::web_programming.fetch_anime_and_play.get_anime_episode
FAILED web_programming/fetch_anime_and_play.py::web_programming.fetch_anime_and_play.search_anime_episode_list
FAILED web_programming/fetch_anime_and_play.py::web_programming.fetch_anime_and_play.search_scraper

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label May 25, 2023
@JadeKim042386 JadeKim042386 changed the title fix: graphs/greedy_best_first typo fix typo graphs/greedy_best_first.py May 25, 2023
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@JadeKim042386 JadeKim042386 force-pushed the typo-greedy_best_first branch from 3d1174c to 198113c Compare May 25, 2023 12:38
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label May 25, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label May 25, 2023
@cclauss cclauss merged commit a17791d into TheAlgorithms:master May 25, 2023
@JadeKim042386 JadeKim042386 deleted the typo-greedy_best_first branch May 26, 2023 03:29
tianyizheng02 pushed a commit to tianyizheng02/Python that referenced this pull request May 29, 2023
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@isidroas isidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I found typo in graphs/greedy_best_first
3 participants