Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a max_sectors_of_circle algorithm #8778

Closed
wants to merge 8 commits into from
Closed

adding a max_sectors_of_circle algorithm #8778

wants to merge 8 commits into from

Conversation

meg-1
Copy link
Contributor

@meg-1 meg-1 commented May 27, 2023

Describe your change:

adding a max_sectors_of_circle algorithm, which returns the maximum amount of sectors a circle can be divided by if cut 'num_cuts' times

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

meg-1 and others added 2 commits June 3, 2023 15:01
Co-authored-by: AmirSoroush <114881632+amirsoroush@users.noreply.github.com>
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Jun 3, 2023
@rohan472000
Copy link
Contributor

@meg-1 , While your solution does provide the expected output and solves the problem, we strive to maintain a repository that focuses on comprehensive algorithms and functions rather than individual one-liners.

Considering the nature of circle-related calculations, I agree that consolidating multiple circle-related questions and algorithms into a dedicated class or module would be a more organized approach. This approach would allow us to cover various aspects of circles, such as sectors, arcs, angles, and segments, while providing detailed explanations and examples.

By adopting this approach, we can ensure that the repository contains meaningful and informative algorithms that cater to a wider range of circle-related concepts. It will also facilitate easier navigation and exploration of circle-related topics for users who are interested in learning about different aspects of circles.

@meg-1
Copy link
Contributor Author

meg-1 commented Jun 21, 2023

Thank you for your time, detailed answer and explanation! I absolutely agree, it would be much more convenient for users to be able to access the information in a collected and structured way. Considering this, do i understand correctly, you are suggesting this example be rewritten with the usage of classes? Or rather, are you suggesting that it'd be a good idea to collect all algorithms in this repo, connected with calculations of various aspects of circles, and to push them all in this commit as a module? Thank you for your answer in advance!

@rohan472000
Copy link
Contributor

yes , You got it right, You should find out all possible or potential question around circles or any polygon(if interested to do), make a class for that polygon under which u will keep different methods to solve those problems.

@rohan472000
Copy link
Contributor

@cclauss is it good to do like above , making class for a polygon to solve its related problems?

following recommendations
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Jun 21, 2023
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhruvmanila Your review on the failing tests?

@algorithms-keeper algorithms-keeper bot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Jun 22, 2023
@dhruvmanila dhruvmanila reopened this Jun 25, 2023
@dhruvmanila dhruvmanila added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Jun 25, 2023
@dhruvmanila dhruvmanila requested a review from cclauss June 25, 2023 19:00
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Jun 25, 2023
@cclauss cclauss closed this Sep 30, 2023
@meg-1 meg-1 mentioned this pull request Nov 3, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants