-
-
Notifications
You must be signed in to change notification settings - Fork 46.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding a max_sectors_of_circle algorithm #8778
Conversation
Co-authored-by: AmirSoroush <114881632+amirsoroush@users.noreply.github.com>
for more information, see https://pre-commit.ci
@meg-1 , While your solution does provide the expected output and solves the problem, we strive to maintain a repository that focuses on comprehensive algorithms and functions rather than individual one-liners. Considering the nature of circle-related calculations, I agree that consolidating multiple circle-related questions and algorithms into a dedicated class or module would be a more organized approach. This approach would allow us to cover various aspects of circles, such as sectors, arcs, angles, and segments, while providing detailed explanations and examples. By adopting this approach, we can ensure that the repository contains meaningful and informative algorithms that cater to a wider range of circle-related concepts. It will also facilitate easier navigation and exploration of circle-related topics for users who are interested in learning about different aspects of circles. |
Thank you for your time, detailed answer and explanation! I absolutely agree, it would be much more convenient for users to be able to access the information in a collected and structured way. Considering this, do i understand correctly, you are suggesting this example be rewritten with the usage of classes? Or rather, are you suggesting that it'd be a good idea to collect all algorithms in this repo, connected with calculations of various aspects of circles, and to push them all in this commit as a module? Thank you for your answer in advance! |
yes , You got it right, You should find out all possible or potential question around circles or any polygon(if interested to do), make a class for that polygon under which u will keep different methods to solve those problems. |
@cclauss is it good to do like above , making class for a polygon to solve its related problems? |
following recommendations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhruvmanila Your review on the failing tests?
Co-authored-by: Christian Clauss <cclauss@me.com>
for more information, see https://pre-commit.ci
Describe your change:
adding a max_sectors_of_circle algorithm, which returns the maximum amount of sectors a circle can be divided by if cut 'num_cuts' times
Checklist:
Fixes: #{$ISSUE_NO}
.