Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Energy conversions #8801

Merged
merged 5 commits into from
Jun 22, 2023
Merged

Energy conversions #8801

merged 5 commits into from
Jun 22, 2023

Conversation

jlhuhn
Copy link
Contributor

@jlhuhn jlhuhn commented Jun 7, 2023

Describe your change:

The energy conversion function allows conversion between various energy units.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@jlhuhn @CaedenPH
Update conversions/energy_conversions.py
9dc97e0 
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
@jlhuhn jlhuhn requested a review from CaedenPH June 7, 2023 22:24
CaedenPH
CaedenPH approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice tests!

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Jun 22, 2023
@cclauss cclauss merged commit f54a966 into TheAlgorithms:master Jun 22, 2023
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@jlhuhn @ShivaDahal99
@CaedenPH @sedatguzelsemme
Energy conversions (TheAlgorithms#8801)
0bbe265 
* Create TestShiva

* Delete TestShiva

* Create energy_conversions.py

* Update conversions/energy_conversions.py

Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>

---------

Co-authored-by: ShivaDahal99 <130563462+ShivaDahal99@users.noreply.github.com>
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@CaedenPH CaedenPH CaedenPH approved these changes

Assignees
No one assigned
Labels
tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jlhuhn @cclauss @CaedenPH @ShivaDahal99