Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create count negative numbers in matrix algorithm #8813

Merged
merged 21 commits into from
Jun 10, 2023
Merged

Create count negative numbers in matrix algorithm #8813

merged 21 commits into from
Jun 10, 2023

Conversation

CaedenPH
Copy link
Contributor

@CaedenPH CaedenPH commented Jun 8, 2023

Describe your change:

Three implementations of this algorithm are implemented and benchmarked together with doctests

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Jun 8, 2023
algorithms-keeper[bot]
algorithms-keeper bot reviewed Jun 8, 2023
View reviewed changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Jun 8, 2023
@algorithms-keeper algorithms-keeper bot removed require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Jun 8, 2023
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Jun 8, 2023
@algorithms-keeper algorithms-keeper bot added the require tests Tests [doctest/unittest/pytest] are required label Jun 8, 2023
algorithms-keeper[bot]
algorithms-keeper bot reviewed Jun 8, 2023
View reviewed changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

@CaedenPH
Copy link
Contributor Author

CaedenPH commented Jun 8, 2023

Note this pr supposedly has lack of tests however the benchmark function shouldn't have doctests anyway
https://github.com/TheAlgorithms/Python/blob/master/ciphers/atbash.py#L41
As shown, this benchmark function doesnt have doctests either

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Jun 8, 2023
@cclauss
Copy link
Member

cclauss commented Jun 9, 2023

When would we want to use this algorithm?

cclauss
cclauss reviewed Jun 9, 2023
View reviewed changes
matrix/count_negative_numbers_in_sorted_matrix.py Outdated
@@ -0,0 +1,164 @@
"""
Given an `m x n` matrix grid which is sorted in non-increasing order
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a validate_matrix(matrix) function? We do not need to run it everywhere but we should have it if we want to validate test input.

@CaedenPH @cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
02cd4f3 
Co-authored-by: Christian Clauss <cclauss@me.com>
@CaedenPH @cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
63c5147 
Co-authored-by: Christian Clauss <cclauss@me.com>
@CaedenPH
Copy link
Contributor Author

CaedenPH commented Jun 9, 2023

When would we want to use this algorithm?

@cclauss If you have a grid of sorted numbers in descending order in a matrix, this algorithm can be used to count the number of negative numbers. Not sure when someone would want to use it, but then again when would someone want to use the quine from other/quine?
As far as I'm aware this repository is just about algorithms, not necessarily useful ones.

To answer your previous comment about validating the matrix, I don't think that is necessary. For searches that require sorted arrays, there aren't checks to ensure that those arrays are sorted so I think indicating that the matrix must be sorted is good enough

cclauss
cclauss requested changes Jun 10, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking cool!!

@CaedenPH @cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
a55db73 
Co-authored-by: Christian Clauss <cclauss@me.com>
CaedenPH and others added 3 commits June 10, 2023 12:40
@CaedenPH @cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
0d8a616 
Co-authored-by: Christian Clauss <cclauss@me.com>
@CaedenPH @cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
9a7719c 
Co-authored-by: Christian Clauss <cclauss@me.com>
@CaedenPH @cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
7a2f01e 
Co-authored-by: Christian Clauss <cclauss@me.com>
@github-actions github-actions bot force-pushed the create-count-negative-numbers-in-matrix branch 2 times, most recently from 0d8a616 to a55db73 Compare June 10, 2023 11:41
algorithms-keeper[bot]
algorithms-keeper bot reviewed Jun 10, 2023
View reviewed changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper[bot]
algorithms-keeper bot reviewed Jun 10, 2023
View reviewed changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Jun 10, 2023
@CaedenPH CaedenPH requested a review from cclauss June 10, 2023 11:53
@CaedenPH
Copy link
Contributor Author

@cclauss All changes have been implemented and tests are passing

@cclauss cclauss enabled auto-merge (squash) June 10, 2023 12:17
cclauss
cclauss approved these changes Jun 10, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for doing this.

@cclauss cclauss merged commit daa0c8f into TheAlgorithms:master Jun 10, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Jun 10, 2023
@cclauss
Copy link
Member

cclauss commented Jun 10, 2023

I have never figured out https://docs.python.org/3/library/bisect.html but it would be interesting to benchmark against an implementation that leveraged it.

sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@CaedenPH @pre-commit-ci
@cclauss @sedatguzelsemme
Create count negative numbers in matrix algorithm (TheAlgorithms#8813)
c26f2ef 
* updating DIRECTORY.md

* feat: Count negative numbers in sorted matrix

* updating DIRECTORY.md

* chore: Fix pre-commit

* refactor: Combine functions into iteration

* style: Reformat reference

* feat: Add timings of each implementation

* chore: Fix problems with algorithms-keeper bot

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* test: Remove doctest from benchmark function

* Update matrix/count_negative_numbers_in_sorted_matrix.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update matrix/count_negative_numbers_in_sorted_matrix.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update matrix/count_negative_numbers_in_sorted_matrix.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update matrix/count_negative_numbers_in_sorted_matrix.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update matrix/count_negative_numbers_in_sorted_matrix.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update matrix/count_negative_numbers_in_sorted_matrix.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* refactor: Use sum instead of large iteration

* refactor: Use len not sum

* Update count_negative_numbers_in_sorted_matrix.py

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algorithms-keeper algorithms-keeper[bot] algorithms-keeper[bot] left review comments

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
require tests Tests [doctest/unittest/pytest] are required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CaedenPH @cclauss