Simplex algorithm #8825
Merged
Simplex algorithm #8825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaedenPH
requested changes
Jun 16, 2023
There was a problem hiding this comment.
- Reformat all your doctests so that the
np.ndarrayutilises the full line length, as shown in one suggestion - In what scenarioes would you enter a different
tableauintopivot,find_pivot, and other functions like this? In the doctests you just ust.tableaubut if you refactor this to not accept a tableau input you can create more concise doctests such asTableau(np.array([[-2,-1,0,0,0], [3,1,1,0,6], [1,2,0,1,7.]]), 2).find_pivot()without having to assign the variablet
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
for more information, see https://pre-commit.ci
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
tests are failing
|
@cclauss here is the simplex algorithm I mentioned in the issue. Please could you review? |
tianyizheng02
requested changes
Jun 17, 2023
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
cclauss
approved these changes
Jun 18, 2023
algorithms-keeper
bot
removed
the
awaiting reviews
sedatguzelsemme
pushed a commit
to sedatguzelsemme/Python
that referenced
this pull request
Sep 15, 2024
* feat: added simplex.py * added docstrings * Update linear_programming/simplex.py Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com> * Update linear_programming/simplex.py Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update linear_programming/simplex.py Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * ruff fix Co-authored by: CaedenPH <caedenperelliharris@gmail.com> * removed README to add in separate PR * Update linear_programming/simplex.py Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com> * Update linear_programming/simplex.py Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com> * fix class docstring * add comments --------- Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Fixes: #8820
Implements the simplex algorithm for solving linear programs.
Adds
linear_programmingfolder.Checklist:
Fixes: #{$ISSUE_NO}.