-
-
Notifications
You must be signed in to change notification settings - Fork 46.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[pre-commit.ci] pre-commit autoupdate (#8872)" #8878
Revert "[pre-commit.ci] pre-commit autoupdate (#8872)" #8878
Conversation
This reverts commit 5aefc00.
@@ -16,12 +16,12 @@ repos: | |||
- id: auto-walrus | |||
|
|||
- repo: https://github.com/astral-sh/ruff-pre-commit | |||
rev: v0.0.278 | |||
rev: v0.0.277 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rev: v0.0.277 | |
rev: v0.0.280 |
And then disable individual rules in pyproject.toml
preferably in per-file-ignores
.
hooks: | ||
- id: ruff | ||
|
||
- repo: https://github.com/psf/black | ||
rev: 23.7.0 | ||
rev: 23.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not go backwards.
@cclauss The rules that are newly implemented seem like good rules. For example, one of the rules states that there can not be more than 20 if/else branches, which is a good rule, and fails on This is a revert pr, so the whole idea is to go back to a working version. If we do not want to do that, I can work on a pull request fixing all the ruff changes instead. |
Look at #8877 for info
This reverts commit 5aefc00.
Reverts #8872
Breaks many algorithms as shown in these failing tests (from this pr #8875) https://github.com/TheAlgorithms/Python/actions/runs/5629561962/job/15254651560?pr=8875
Checklist: