Add Docker devcontainer configuration files #8887
Conversation
Copy and install requirements
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
awaiting changes
algorithms-keeper
bot
added
awaiting reviews
| "extensions": [ | ||
| "ms-python.python", | ||
| "ms-python.vscode-pylance" | ||
| ] |
There was a problem hiding this comment.
In a future PR, it would be cool to add... https://github.com/astral-sh/ruff-vscode
algorithms-keeper
bot
added
awaiting changes
Co-authored-by: Christian Clauss <cclauss@me.com>
algorithms-keeper
bot
added
awaiting reviews
cclauss
changed the title
There was a problem hiding this comment.
As cclauss mentioned, we have a gitpod config file, and I don't see much value in adding devcontainer config files, primarily due to the fact that this is unlike other repositories, and that it is a group of standalone files that don't require much, if any config
This also only customises for a singular tool, vscode, excluding other text editors/IDE's
Even still, if this is decided to be merged, perhaps it would be ideal to add information on how to set up this container in the CONTRIBUTING.md
|
Some people might prefer a local development container, and VSCode is a very good IDE, and platform independent, so I thought this might be a good idea |
There was a problem hiding this comment.
Let's see if this AND GitPod can cohabitate without nullifying each other. Contributors can choose their favorite.
Let's reserve the right to revert this contribution if users protest or if it does not bring sufficient value.
@CaedenPH is correct that we need docs in CONTRIBUTING.md so @HManiac74 please create a follow-on PR that helps folks to get started.
* Added Docker container configuration files * Update Dockerfile Copy and install requirements * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updated Docker devcontainer configuration * Update requierements.txt * Update Dockerfile * Update Dockerfile * Update .devcontainer/devcontainer.json Co-authored-by: Christian Clauss <cclauss@me.com> * Update Dockerfile * Update Dockerfile. Add linebreak --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Christian Clauss <cclauss@me.com>
Added configuration files for running the repo in a Docker dev Container