Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ruff rules ISC flake8-implicit-str-concat #8891

Closed
wants to merge 3 commits into from
Closed

Fix ruff rules ISC flake8-implicit-str-concat #8891

wants to merge 3 commits into from

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Jul 26, 2023 •
edited
Loading

Fixes #8892

Describe your change:

This PR was created in a dev container to test it out.
https://beta.ruff.rs/docs/rules/#flake8-implicit-str-concat-isc

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@cclauss cclauss enabled auto-merge (squash) July 26, 2023 06:26
@cclauss cclauss force-pushed the ruff-rule-ISC001 branch from 7034306 to 553ff17 Compare July 26, 2023 06:57
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Jul 26, 2023
@cclauss cclauss marked this pull request as draft July 26, 2023 07:04
auto-merge was automatically disabled July 26, 2023 07:04

Pull request was converted to draft

@cclauss cclauss marked this pull request as ready for review July 26, 2023 07:13
@algorithms-keeper
Copy link

Closing this pull request as invalid

@cclauss, this pull request is being closed as the files submitted contains an invalid extension. This repository only accepts Python algorithms. Please read the Contributing guidelines first.

Invalid files in this pull request: .devcontainer/Dockerfile

@algorithms-keeper algorithms-keeper bot removed the request for review from dhruvmanila July 26, 2023 07:14
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Jul 26, 2023
@cclauss cclauss reopened this Jul 26, 2023
@cclauss cclauss requested a review from dhruvmanila as a code owner July 26, 2023 07:14
@algorithms-keeper
Copy link

Closing this pull request as invalid

@cclauss, this pull request is being closed as the files submitted contains an invalid extension. This repository only accepts Python algorithms. Please read the Contributing guidelines first.

Invalid files in this pull request: .devcontainer/Dockerfile

@algorithms-keeper algorithms-keeper bot removed the request for review from dhruvmanila July 26, 2023 07:14
@cclauss
Copy link
Member Author

cclauss commented Jul 26, 2023

@dhruvmanila Please enable algorithms-keeper to understand that Dockerfile is acceptable or to ignore the contents of .devcontainer.

@cclauss cclauss reopened this Jul 26, 2023
@algorithms-keeper
Copy link

Closing this pull request as invalid

@cclauss, this pull request is being closed as the files submitted contains an invalid extension. This repository only accepts Python algorithms. Please read the Contributing guidelines first.

Invalid files in this pull request: .devcontainer/Dockerfile

@cclauss cclauss requested a review from dhruvmanila July 26, 2023 07:18
@cclauss cclauss mentioned this pull request Jul 26, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruppysuppy ruppysuppy ruppysuppy approved these changes

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees
No one assigned
Labels
invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @ruppysuppy