Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create is valid email address algorithm #8907

Merged
merged 9 commits into from
Aug 14, 2023
Merged

Create is valid email address algorithm #8907

merged 9 commits into from
Aug 14, 2023

Conversation

CaedenPH
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

tianyizheng02
tianyizheng02 requested changes Aug 1, 2023
View reviewed changes
@CaedenPH CaedenPH requested a review from tianyizheng02 August 10, 2023 14:14
@CaedenPH
Copy link
Contributor Author

@tianyizheng02 Again apologies for late response - requesting review

tianyizheng02
tianyizheng02 requested changes Aug 14, 2023
View reviewed changes
@CaedenPH @tianyizheng02
Update strings/is_valid_email_address.py
bfec37c 
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
tianyizheng02
tianyizheng02 approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianyizheng02 tianyizheng02 merged commit 4b7ecb6 into TheAlgorithms:master Aug 14, 2023
@CaedenPH CaedenPH deleted the create-is-valid-email branch August 14, 2023 08:36
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@CaedenPH @tianyizheng02
@pre-commit-ci @sedatguzelsemme
Create is valid email address algorithm (TheAlgorithms#8907)
9d5b70b 
* feat(strings): Create is valid email address

* updating DIRECTORY.md

* feat(strings): Create is_valid_email_address algorithm

* chore(is_valid_email_address): Implement changes from code review

* Update strings/is_valid_email_address.py

Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* chore(is_valid_email_address): Fix ruff error

* Update strings/is_valid_email_address.py

Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madhavgaba madhavgaba madhavgaba left review comments

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CaedenPH @madhavgaba @tianyizheng02