Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruff fixes #8913

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Ruff fixes #8913

merged 3 commits into from
Jul 31, 2023

Conversation

tianyizheng02
Copy link
Contributor

Describe your change:

Fix graphs/eulerian_path_and_circuit_for_undirected_graph.py and physics/newtons_second_law_of_motion.py, which are causing ruff to fail

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@tianyizheng02 tianyizheng02 requested a review from cclauss July 31, 2023 19:56
@tianyizheng02 tianyizheng02 mentioned this pull request Jul 31, 2023
Merged
14 tasks
@tianyizheng02 tianyizheng02 merged commit 5cf34d9 into TheAlgorithms:master Jul 31, 2023
@tianyizheng02 tianyizheng02 deleted the fix-failing-ruff branch July 31, 2023 20:53
@cclauss cclauss requested a review from dhruvmanila July 31, 2023 20:53
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@tianyizheng02 @sedatguzelsemme
Ruff fixes (TheAlgorithms#8913)
31cfe6b 
* updating DIRECTORY.md

* Fix ruff error in eulerian_path_and_circuit_for_undirected_graph.py

* Fix ruff error in newtons_second_law_of_motion.py

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tianyizheng02 @cclauss