Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements to jump_search.py #8932

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

amirsoroush
Copy link
Contributor

@amirsoroush amirsoroush commented Aug 8, 2023

Describe your change:

Here are a few minor improvements to the current implementation of jump_search.py algorithm.

  1. int(math.floor(math.sqrt(n))) is the same thing as int(math.sqrt(n)) and it can be calculated once.
  2. Better naming for variables.
  3. Add type hints which indicates that this function can also work with other sequence types as long as they are comparable.
  4. prev = prev + 1 --> prev += 1

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Aug 8, 2023
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements

@tianyizheng02 tianyizheng02 merged commit 842d03f into TheAlgorithms:master Aug 8, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Aug 8, 2023
@amirsoroush amirsoroush deleted the patch-1 branch August 9, 2023 14:41
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
* improvements to jump_search.py

* add more tests to jump_search.py
@isidroas isidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants