Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated the URL and HTML tags for scrapping yahoo finance #8942

Merged
merged 4 commits into from
Aug 12, 2023
Merged

updated the URL and HTML tags for scrapping yahoo finance #8942

merged 4 commits into from
Aug 12, 2023

Conversation

Suman2023
Copy link
Contributor

The existing Yahoo URL for scrapping the stock price is no longer maintained from August 26th, 2021 (attached the screenshot below). Moreover there is a change in HTML tags for the current price field. I have added the new URL and have updated the HTML tags required to fetch the current price of the stock.

Screenshot 2023-08-10 203953

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@Suman2023 Suman2023 requested a review from cclauss as a code owner August 10, 2023 15:19
@Suman2023
Copy link
Contributor Author

Suman2023 commented Aug 10, 2023 •
edited
Loading

@cclauss This is my first contribution will really appreciate some feedback

tianyizheng02
tianyizheng02 requested changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the most part, but I'll still have to verify whether the new URL works correctly myself when I get the chance.

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Aug 11, 2023
@tianyizheng02 tianyizheng02 linked an issue Aug 11, 2023 that may be closed by this pull request
web_programming/current_stock_price.py no longer works #8950
Closed
tianyizheng02
tianyizheng02 approved these changes Aug 12, 2023
View reviewed changes
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that the fix works, LGTM

@tianyizheng02 tianyizheng02 merged commit c39b7ea into TheAlgorithms:master Aug 12, 2023
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@Suman2023 @pre-commit-ci @sedatguzelsemme
updated the URL and HTML tags for scrapping yahoo finance (TheAlgorit…
8681d06 
…hms#8942)

* updated the url and tags for yahoo finance

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* updated to return the error text

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

@cclauss cclauss Awaiting requested review from cclauss cclauss is a code owner

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

web_programming/current_stock_price.py no longer works
2 participants
@Suman2023 @tianyizheng02