Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update arc_length.py #8964

Merged
merged 5 commits into from
Aug 20, 2023
Merged

Update arc_length.py #8964

merged 5 commits into from
Aug 20, 2023

Conversation

Guduly
Copy link
Contributor

@Guduly Guduly commented Aug 16, 2023

Wrote the output of testcase

Describe your change:

Added a comment to show output of the testcase.
Please tell me if I made an error, thank you.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Guduly and others added 2 commits August 15, 2023 20:09
tianyizheng02
tianyizheng02 requested changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding the expected output as a comment, could you add this as a test in the docstring?

>>> arc_length(90, 10)
15.7079632679

That way, we can use unit testing to ensure that the output is actually correct.

@Guduly
Update arc_length.py
668ef1f 
Added the requested changes
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Aug 17, 2023
@Guduly
Copy link
Contributor Author

Guduly commented Aug 17, 2023

Changes made

@Nikhil2201005

This comment was marked as off-topic.

Sign in to view
tianyizheng02
tianyizheng02 requested changes Aug 17, 2023
View reviewed changes
@Guduly
Update arc_length.py
8691180 
followed the change request
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Aug 18, 2023
tianyizheng02
tianyizheng02 requested changes Aug 19, 2023
View reviewed changes
@Guduly
Update arc_length.py
c1c09fc 
followed suggestions
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Aug 20, 2023
@tianyizheng02 tianyizheng02 merged commit 672e7bd into TheAlgorithms:master Aug 20, 2023
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@Guduly @pre-commit-ci @sedatguzelsemme
Update arc_length.py (TheAlgorithms#8964)
d16e5d7 
* Update arc_length.py

Wrote the output of testcase

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update arc_length.py

Added the requested changes

* Update arc_length.py

followed the change request

* Update arc_length.py

followed suggestions

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madhavgaba madhavgaba madhavgaba approved these changes

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Guduly @Nikhil2201005 @madhavgaba @tianyizheng02