Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type errors in permutations #9007

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 13 additions & 15 deletions data_structures/arrays/permutations.py
Original file line number Diff line number Diff line change
@@ -1,33 +1,32 @@
def permute(nums: list[int]) -> list[list[int]]:
def permute_recursive(nums: list[int]) -> list[list[int]]:
"""
Return all permutations.
>>> from itertools import permutations
>>> numbers= [1,2,3]
>>> all(list(nums) in permute(numbers) for nums in permutations(numbers))
True

>>> permute_recursive([1, 2, 3])
[[3, 2, 1], [2, 3, 1], [1, 3, 2], [3, 1, 2], [2, 1, 3], [1, 2, 3]]
"""
result = []
if len(nums) == 1:
return [nums.copy()]
result: list[list[int]] = []
if len(nums) == 0:
return [[]]
for _ in range(len(nums)):
n = nums.pop(0)
permutations = permute(nums)
permutations = permute_recursive(nums)
for perm in permutations:
perm.append(n)
result.extend(permutations)
nums.append(n)
return result


def permute2(nums):
def permute_backtrack(nums: list[int]) -> list[list[int]]:
"""
Return all permutations of the given list.

>>> permute2([1, 2, 3])
>>> permute_backtrack([1, 2, 3])
[[1, 2, 3], [1, 3, 2], [2, 1, 3], [2, 3, 1], [3, 2, 1], [3, 1, 2]]
"""

def backtrack(start):
def backtrack(start: int) -> None:
if start == len(nums) - 1:
output.append(nums[:])
else:
Expand All @@ -36,15 +35,14 @@ def backtrack(start):
backtrack(start + 1)
nums[start], nums[i] = nums[i], nums[start] # backtrack

output = []
output: list[list[int]] = []
backtrack(0)
return output


if __name__ == "__main__":
import doctest

# use res to print the data in permute2 function
res = permute2([1, 2, 3])
res = permute_backtrack([1, 2, 3])
print(res)
doctest.testmod()