Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update actions/checkout with fetch-depth: 0 #9046

Merged
merged 6 commits into from
Sep 9, 2023
Merged

Update actions/checkout with fetch-depth: 0 #9046

merged 6 commits into from
Sep 9, 2023

Conversation

Saransh-cpp
Copy link
Contributor

@Saransh-cpp Saransh-cpp commented Sep 9, 2023 •
edited
Loading

Describe your change:

See Saransh-cpp/github-stats.#1

cc: @cclauss

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@cclauss
Copy link
Member

cclauss commented Sep 9, 2023 •
edited
Loading

@dhruvmanila @tianyizheng02 I am trying to get our directory_writer GitHub Action to run on this pull request.
If I modify directory_writer.yml or add a new .py file shouldn't that kick off a run of that job?

@Saransh-cpp
Copy link
Contributor Author

The workflow is not enabled for PRs from a fork -

Python/.github/workflows/directory_writer.yml

Lines 3 to 4 in c9b4b80

name: directory_writer
on: [push]

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Sep 9, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Sep 9, 2023
@cclauss cclauss merged commit 5a5ca06 into TheAlgorithms:master Sep 9, 2023
@Saransh-cpp Saransh-cpp deleted the patch-1 branch September 10, 2023 06:00
tianyizheng02
tianyizheng02 reviewed Sep 16, 2023
View reviewed changes
arithmetic_analysis/junk.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there this empty file??

@tianyizheng02 tianyizheng02 mentioned this pull request Sep 16, 2023
Merged
14 tasks
@cclauss
Copy link
Member

cclauss commented Sep 16, 2023

arithmetic_analysis/junk.py can be deleted.

@tianyizheng02
Copy link
Contributor

See #9062

sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@Saransh-cpp @cclauss
@pre-commit-ci @sedatguzelsemme
Update actions/checkout with fetch-depth: 0 (TheAlgorithms#9046)
1020120 
* Update `actions/checkout` with `fetch-depth: 0`

* Update directory_writer.yml

* Create junk.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update directory_writer.yml

* Update directory_writer.yml

---------

Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 left review comments

@cclauss cclauss cclauss approved these changes

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Saransh-cpp @cclauss @tianyizheng02