Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #8063 #9108

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Fixes #8063 #9108

merged 2 commits into from
Sep 27, 2023

Conversation

aryan1165
Copy link
Contributor

@aryan1165 aryan1165 commented Sep 27, 2023 •
edited by cclauss
Loading

Describe your change:

Fixes #8063

  • Deleted math/euclidean.py.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@aryan1165 aryan1165 mentioned this pull request Sep 27, 2023
Closed
@cclauss
Copy link
Member

cclauss commented Sep 27, 2023

Please remove the space before each x in the commit message above.

@cclauss cclauss self-assigned this Sep 27, 2023
@aryan1165
Copy link
Contributor Author

Done. Thanks for pointing out.

@cclauss cclauss enabled auto-merge (squash) September 27, 2023 13:55
@cclauss cclauss merged commit 38c2b83 into TheAlgorithms:master Sep 27, 2023
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@aryan1165 @sedatguzelsemme
Deleted euclidean_gcd.py. Fixes#8063 (TheAlgorithms#9108)
9a81400
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

@cclauss cclauss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove duplicate GCD implementation
2 participants
@aryan1165 @cclauss