Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy error in web_programming/reddit.py #9162

Merged
merged 3 commits into from
Oct 1, 2023

Conversation

tianyizheng02
Copy link
Contributor

Describe your change:

In recent PRs such as #9160, mypy is failing in the pre-commit check because of the following error:

web_programming/reddit.py:36: error: Missing named argument "response" for "HTTPError"  [call-arg]

This happens even though contributors aren't modifying web_programming/reddit.py. I'm not sure why this mypy error is appearing now, but this appears to fix it.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@tianyizheng02 tianyizheng02 requested a review from cclauss as a code owner October 1, 2023 02:45
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 1, 2023
github-actions and others added 3 commits September 30, 2023 23:01
web_programming/reddit.py:36: error: Missing named argument "response" for "HTTPError"  [call-arg]
@ChrisO345 ChrisO345 merged commit aaf7195 into TheAlgorithms:master Oct 1, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 1, 2023
@tianyizheng02 tianyizheng02 deleted the fix-reddit branch October 1, 2023 03:12
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
* updating DIRECTORY.md

* updating DIRECTORY.md

* Fix mypy error in web_programming/reddit.py

web_programming/reddit.py:36: error: Missing named argument "response" for "HTTPError"  [call-arg]

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants