Create energy_mass.py #9199
Closed
Create energy_mass.py #9199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added the energy mass equivalence in physics directory
algorithms-keeper
bot
added
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
physics/energy_mass.py
Outdated
|
|
||
| c_const = 299792458 | ||
|
|
||
| def energy_mass (mass : float): |
There was a problem hiding this comment.
Please provide return type hint for the function: energy_mass. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file physics/energy_mass.py, please provide doctest for the function energy_mass
for more information, see https://pre-commit.ci
ChrisO345
requested changes
Oct 2, 2023
| c_const = 299792458 | ||
|
|
||
|
|
||
| def energy_mass(mass: float): |
There was a problem hiding this comment.
Suggested change
| def energy_mass(mass: float): | |
| def energy_mass(mass: float) -> float: |
| c_const = 299792458 | ||
|
|
||
|
|
||
| def energy_mass(mass: float): |
There was a problem hiding this comment.
Can you add doctests to this function
| if mass <= 0: | ||
| raise ValueError("Invalid inputs. Enter positive value for mass") | ||
|
|
||
| return mass * (c_const ^ 2) |
There was a problem hiding this comment.
Suggested change
| return mass * (c_const ^ 2) | |
| return mass * (c_const ** 2) |
|
This is too trivial. See #9191 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added the energy mass equivalence in physics directory
Describe your change:
Have added the energy_mass equivalence functionality in the correct repository as mentioned.
Checklist: