Skip to content

Minimum platforms issue 9119 #9222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Minimum platforms issue 9119 #9222

wants to merge 7 commits into from

Conversation

dev-soni-07
Copy link

@dev-soni-07 dev-soni-07 commented Oct 1, 2023

Contribution Overview:

  • Created a new Python file minimum_platforms.py containing the Minimum Number of Platforms algorithm.
  • Included Python type hints for function parameters and return values.
  • Ensured the code adheres to the project's coding style and follows PEP 8 guidelines.
  • Ran doctests locally to verify correctness.

Additional Details:

  • The Minimum Number of Platforms algorithm is a fundamental problem in logistics and transportation scheduling.
  • The algorithm calculates the minimum number of platforms required to avoid delays and congestion in transportation systems.
  • Properly formatted the code using black for readability.
  • Included doctests to illustrate and verify the algorithm's correctness.
  • Tested locally using Python 3.11+ and mypy for type checking.

Related Issues:

Checklist:

  • Created the new file minimum_platforms.py.
  • Included Python type hints for function parameters and return values.
  • Formatted the code using black.
  • Ran doctests locally to verify correctness.

I'm excited to contribute to TheAlgorithms/Python and would appreciate your review and feedback. Please let me know if any further improvements are needed. Thank you!

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Oct 1, 2023
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 1, 2023
@algorithms-keeper algorithms-keeper bot removed the require type hints https://docs.python.org/3/library/typing.html label Oct 1, 2023
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 1, 2023
@cclauss
Copy link
Member

cclauss commented Oct 4, 2023

This pull request has unresolved git conflicts. Closing because we currently have more than 100 open pull requests.

@cclauss cclauss closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files require tests Tests [doctest/unittest/pytest] are required tests are failing Do not merge until tests pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Addition of Minimum Number of Platforms (Greedy Algorithm)
2 participants