Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance readability of N Queens #9265

Merged
merged 4 commits into from
Oct 22, 2023
Merged

Enhance readability of N Queens #9265

merged 4 commits into from
Oct 22, 2023

Conversation

Hardvan
Copy link
Contributor

@Hardvan Hardvan commented Oct 1, 2023 •
edited
Loading

Enhanced readability and added comments to the n_queens.py code. Replaced repeated len(board) with a single variable n for efficiency in the is_safe function.

  • Fix a bug or typo in an existing algorithm?
  • Add an algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Additional Information:

This pull request improves the readability of the n_queens.py code and optimizes the is_safe function by replacing repeated calls to len(board) with a single variable n. These changes make the code more understandable and efficient.

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 1, 2023
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 1, 2023
@algorithms-keeper algorithms-keeper bot mentioned this pull request Oct 1, 2023
Closed
14 tasks
tianyizheng02
tianyizheng02 approved these changes Oct 22, 2023
View reviewed changes
@tianyizheng02 tianyizheng02 merged commit a8b94ab into TheAlgorithms:master Oct 22, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 22, 2023
@Hardvan Hardvan deleted the hardvan-branch branch October 23, 2023 12:38
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@Hardvan @pre-commit-ci
@tianyizheng02 @sedatguzelsemme
Enhance readability of N Queens (TheAlgorithms#9265)
0d5ce7b 
* Enhance readability of N Queens

* Simplify is_safe code

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Apply suggestions from code review

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hardvan @tianyizheng02