Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed maths/binary_exponentiation_2.py to binary_multiplication.py #9521

Closed
wants to merge 3 commits into from
Closed

Renamed maths/binary_exponentiation_2.py to binary_multiplication.py #9521

wants to merge 3 commits into from

Conversation

Chetan7378
Copy link

@Chetan7378 Chetan7378 commented Oct 2, 2023 •
edited
Loading

Describe your change:

This PR renames binary_exponentiation_2.py to binary_multiplication.py
and renames #!/usr/bin/env python3 to #!/usr/bin/env python
Fixes #9478

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 2, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 2, 2023
@Chetan7378
Copy link
Author

Review my PR

@tianyizheng02
Copy link
Contributor

Fixed in #9513

@tianyizheng02
Copy link
Contributor

I reviewed a different PR for the issue because this one doesn't address the issue of the file not having any doctests

@Chetan7378 Chetan7378 deleted the fix/binary_exponentiation_2.py branch October 4, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

maths/binary_exponentiation_2.py needs to be renamed
2 participants
@Chetan7378 @tianyizheng02