Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pre-commit.ci] pre-commit autoupdate #9543

Merged
merged 6 commits into from
Oct 7, 2023
Merged

[pre-commit.ci] pre-commit autoupdate #9543

merged 6 commits into from
Oct 7, 2023

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Oct 2, 2023

@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
a7c7a4d 
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.0.291 → v0.0.292](astral-sh/ruff-pre-commit@v0.0.291...v0.0.292)
- [github.com/codespell-project/codespell: v2.2.5 → v2.2.6](codespell-project/codespell@v2.2.5...v2.2.6)
- [github.com/tox-dev/pyproject-fmt: 1.1.0 → 1.2.0](tox-dev/pyproject-fmt@1.1.0...1.2.0)
@tianyizheng02
Copy link
Contributor

The pre-commit failures are coming from typos in various files

@akshatvermavi
Copy link

hi, @tianyizheng02 could you assign this pr to me

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 7, 2023
@cclauss
Copy link
Member

cclauss commented Oct 7, 2023

You can codespell -w and it will fix the typos across multiple files.

@algorithms-keeper algorithms-keeper bot added the merge conflicts Open a new PR or rebase on the latest commit label Oct 7, 2023
@algorithms-keeper algorithms-keeper bot removed the merge conflicts Open a new PR or rebase on the latest commit label Oct 7, 2023
@tianyizheng02
Copy link
Contributor

You can codespell -w and it will fix the typos across multiple files.

@cclauss I didn't want to have codespell auto-fix the typos because some of them are false positives. Currently codespell is failing because it thinks "Manuel" (the name) is a misspelling of "Manual".

tianyizheng02
tianyizheng02 reviewed Oct 7, 2023
View reviewed changes
pyproject.toml
@@ -130,5 +130,5 @@ omit = [".env/*"]
sort = "Cover"

[tool.codespell]
ignore-words-list = "3rt,ans,crate,damon,fo,followings,hist,iff,kwanza,mater,secant,som,sur,tim,zar"
ignore-words-list = "3rt,ans,crate,damon,fo,followings,hist,iff,kwanza,manuel,mater,secant,som,sur,tim,zar"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ignore-words-list = "3rt,ans,crate,damon,fo,followings,hist,iff,kwanza,manuel,mater,secant,som,sur,tim,zar"
ignore-words-list = "3rt,ans,crate,damon,fo,followings,hist,iff,kwanza,Manuel,mater,secant,som,sur,tim,zar"

Not entirely sure how codespell handles ignored words, but would this help codespell recognize "Manuel" as a name while still catching "manuel" as a typo?

Copy link
Member

@cclauss cclauss Oct 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These values MUST all be in lowercase as discussed in the codespell docs.

Tests seem to be passing below.

@cclauss cclauss merged commit 895dffb into master Oct 7, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 7, 2023
@cclauss cclauss deleted the pre-commit-ci-update-config branch October 7, 2023 19:32
tianyizheng02 added a commit to tianyizheng02/Python that referenced this pull request Oct 8, 2023
@pre-commit-ci @tianyizheng02 @cclauss
[pre-commit.ci] pre-commit autoupdate (TheAlgorithms#9543)
920a8b5 
* [pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.0.291 → v0.0.292](astral-sh/ruff-pre-commit@v0.0.291...v0.0.292)
- [github.com/codespell-project/codespell: v2.2.5 → v2.2.6](codespell-project/codespell@v2.2.5...v2.2.6)
- [github.com/tox-dev/pyproject-fmt: 1.1.0 → 1.2.0](tox-dev/pyproject-fmt@1.1.0...1.2.0)

* updating DIRECTORY.md

* Fix typos in test_min_spanning_tree_prim.py

* Fix typos

* codespell --ignore-words-list=manuel

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@pre-commit-ci @tianyizheng02
@cclauss @sedatguzelsemme
[pre-commit.ci] pre-commit autoupdate (TheAlgorithms#9543)
32c9bda 
* [pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.0.291 → v0.0.292](astral-sh/ruff-pre-commit@v0.0.291...v0.0.292)
- [github.com/codespell-project/codespell: v2.2.5 → v2.2.6](codespell-project/codespell@v2.2.5...v2.2.6)
- [github.com/tox-dev/pyproject-fmt: 1.1.0 → 1.2.0](tox-dev/pyproject-fmt@1.1.0...1.2.0)

* updating DIRECTORY.md

* Fix typos in test_min_spanning_tree_prim.py

* Fix typos

* codespell --ignore-words-list=manuel

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

@cclauss cclauss Awaiting requested review from cclauss cclauss is a code owner

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tianyizheng02 @akshatvermavi @cclauss