Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade our Devcontainer to Python 3.12 on Debian bookworm #9580

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Oct 3, 2023

Describe your change:

Repeats #9578

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@cclauss cclauss requested a review from dhruvmanila as a code owner October 3, 2023 09:23
@algorithms-keeper
Copy link

Closing this pull request as invalid

@cclauss, this pull request is being closed as the files submitted contains an invalid extension. This repository only accepts Python algorithms. Please read the Contributing guidelines first.

Invalid files in this pull request: .devcontainer/Dockerfile

@algorithms-keeper algorithms-keeper bot closed this Oct 3, 2023
@algorithms-keeper algorithms-keeper bot removed the request for review from dhruvmanila October 3, 2023 09:23
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 3, 2023
@dhruvmanila
Copy link
Member

Oh, the ACCEPTED_EXTENSIONS doesn't work like that, sorry didn't realize what you were trying to do.

@cclauss
Copy link
Member Author

cclauss commented Oct 3, 2023

I cannot yet brew install python@3.12 and I needed a Py3.12 environment to fix #9581 but I will just keep doing GHA builds to get that green.

@dhruvmanila dhruvmanila reopened this Oct 3, 2023
@algorithms-keeper algorithms-keeper bot added the enhancement This PR modified some existing files label Oct 3, 2023
@cclauss cclauss enabled auto-merge (squash) October 3, 2023 09:43
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 3, 2023
@cclauss cclauss force-pushed the Python-3.12-on-Debian-bookworm branch from 1a9b5f6 to b7a93a4 Compare October 3, 2023 09:52
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 3, 2023
@cclauss cclauss requested a review from ChrisO345 October 3, 2023 10:01
@cclauss cclauss merged commit e60779c into master Oct 3, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 3, 2023
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@isidroas isidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants