-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CreateBase_minus2.py #9658
CreateBase_minus2.py #9658
Conversation
Fixes TheAlgorithms#9588 This code defines a decimal_to_base_minus_2 function that takes a decimal number as input and converts it to base -2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper
commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper review
to trigger the checks for only added pull request files@algorithms-keeper review-all
to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
@@ -0,0 +1,22 @@ | |||
def decimal_to_base_minus_2(n): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there is no test file in this pull request nor any test function or class in the file Base_minus2.py
, please provide doctest for the function decimal_to_base_minus_2
Please provide return type hint for the function: decimal_to_base_minus_2
. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide descriptive name for the parameter: n
Please provide type hint for the parameter: n
for more information, see https://pre-commit.ci
Duplicate of #9659 |
Marking this older PR as the duplicate because it's the less fleshed out of the two |
Fixes #9588
This code defines a decimal_to_base_minus_2 function that takes a decimal number as input and converts it to base -2.
Describe your change:
Checklist: