Stewart's Theorem #9779

rtang09 · 2023-10-05T06:27:36Z

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

for more information, see https://pre-commit.ci

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2023-10-05T06:27:42Z

maths/stewart.py

+Source: https://en.wikipedia.org/wiki/Stewart%27s_theorem
+'''
+
+def stewart(a:float,b:float,c:float,n:float,m:float) -> float:


Please provide descriptive name for the parameter: a

Please provide descriptive name for the parameter: b

Please provide descriptive name for the parameter: c

Please provide descriptive name for the parameter: n

Please provide descriptive name for the parameter: m

for more information, see https://pre-commit.ci

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2023-10-05T06:32:16Z

maths/stewart.py

+Source: https://en.wikipedia.org/wiki/Stewart%27s_theorem
+'''
+
+def stewart(a:float,b:float,c:float,n:float,m:float) -> float:


Please provide descriptive name for the parameter: a

Please provide descriptive name for the parameter: b

Please provide descriptive name for the parameter: c

Please provide descriptive name for the parameter: n

Please provide descriptive name for the parameter: m

for more information, see https://pre-commit.ci

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2023-10-05T06:36:28Z

maths/stewart.py

+Source: https://en.wikipedia.org/wiki/Stewart%27s_theorem
+'''
+
+def stewart(a:float,b:float,c:float,n:float,m:float) -> float:


Please provide descriptive name for the parameter: a

Please provide descriptive name for the parameter: b

Please provide descriptive name for the parameter: c

Please provide descriptive name for the parameter: n

Please provide descriptive name for the parameter: m

for more information, see https://pre-commit.ci

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2023-10-05T07:06:19Z

maths/stewart.py

+"""
+
+
+def stewart(a: float, b: float, c: float, n: float, m: float) -> float:


Please provide descriptive name for the parameter: a

Please provide descriptive name for the parameter: b

Please provide descriptive name for the parameter: c

Please provide descriptive name for the parameter: n

Please provide descriptive name for the parameter: m

for more information, see https://pre-commit.ci

cclauss · 2023-10-05T09:22:13Z

To clear out hashes/fletcher16.py which already was merged, go to https://github.com/rtang09/Python and then click the Sync fork and then Update branch buttons.

tianyizheng02 · 2023-10-05T10:57:39Z

This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.

Also, you already added the Fletcher16 algorithm in #9775

cclauss · 2023-10-05T11:03:04Z

@tianyizheng02 Please see my comment above yours. This will happen when users create pull requests on their master branch and then do not rebase after one of their pull requests is merged. The whole git rebase process can be confusing to newcomers so GitHub has provided the Sync fork / Update branch capability to help ease the pain.

Our CONTRIBUTING.md should emphasize not creating PRs on the master branch but perfect execution is difficult.

rtang09 and others added 10 commits October 4, 2023 21:45

Add files via upload

e300cbf

Update fletcher16.py

ac7cdba

Update fletcher16.py

79feadf

[pre-commit.ci] auto fixes from pre-commit.com hooks

f4427ba

for more information, see https://pre-commit.ci

Update fletcher16.py

b4ec72f

[pre-commit.ci] auto fixes from pre-commit.com hooks

d141fee

for more information, see https://pre-commit.ci

Update fletcher16.py

45e79a7

[pre-commit.ci] auto fixes from pre-commit.com hooks

a28d3c7

for more information, see https://pre-commit.ci

Update fletcher16.py

114e415

Add files via upload

7a28e89

algorithms-keeper bot added the require descriptive names This PR needs descriptive function and/or variable names label Oct 5, 2023

algorithms-keeper bot reviewed Oct 5, 2023

View reviewed changes

algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 5, 2023

[pre-commit.ci] auto fixes from pre-commit.com hooks

7d7d0c3

for more information, see https://pre-commit.ci

algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 5, 2023

Update stewart.py

7b8ef6c

algorithms-keeper bot reviewed Oct 5, 2023

View reviewed changes

pre-commit-ci bot and others added 2 commits October 5, 2023 06:32

[pre-commit.ci] auto fixes from pre-commit.com hooks

05cdc34

for more information, see https://pre-commit.ci

Update stewart.py

f4f7fb5

algorithms-keeper bot reviewed Oct 5, 2023

View reviewed changes

pre-commit-ci bot and others added 2 commits October 5, 2023 06:37

[pre-commit.ci] auto fixes from pre-commit.com hooks

7864c2a

for more information, see https://pre-commit.ci

Add files via upload

e2accc7

algorithms-keeper bot reviewed Oct 5, 2023

View reviewed changes

[pre-commit.ci] auto fixes from pre-commit.com hooks

1611ec2

for more information, see https://pre-commit.ci

tianyizheng02 closed this Oct 5, 2023

tianyizheng02 added duplicate This is a duplicate PR from the same user multiple algorithms not allowed Multiple algorithms in a single PR are not allowed labels Oct 5, 2023

tianyizheng02 removed the duplicate This is a duplicate PR from the same user label Oct 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stewart's Theorem #9779

Stewart's Theorem #9779

rtang09 commented Oct 5, 2023

algorithms-keeper bot left a comment

algorithms-keeper bot Oct 5, 2023

algorithms-keeper bot left a comment

algorithms-keeper bot Oct 5, 2023

algorithms-keeper bot left a comment

algorithms-keeper bot Oct 5, 2023

algorithms-keeper bot left a comment

algorithms-keeper bot Oct 5, 2023

cclauss commented Oct 5, 2023

tianyizheng02 commented Oct 5, 2023

cclauss commented Oct 5, 2023 •

edited

Loading

		"""


		def stewart(a: float, b: float, c: float, n: float, m: float) -> float:

Stewart's Theorem #9779

Stewart's Theorem #9779

Conversation

rtang09 commented Oct 5, 2023

Describe your change:

Checklist:

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

algorithms-keeper bot Oct 5, 2023

Choose a reason for hiding this comment

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

algorithms-keeper bot Oct 5, 2023

Choose a reason for hiding this comment

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

algorithms-keeper bot Oct 5, 2023

Choose a reason for hiding this comment

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

algorithms-keeper bot Oct 5, 2023

Choose a reason for hiding this comment

cclauss commented Oct 5, 2023

tianyizheng02 commented Oct 5, 2023

cclauss commented Oct 5, 2023 • edited Loading

cclauss commented Oct 5, 2023 •

edited

Loading