Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

largest divisible subset #9825

Merged
merged 13 commits into from
Oct 5, 2023
Merged

largest divisible subset #9825

merged 13 commits into from
Oct 5, 2023

Conversation

pa-kh039
Copy link
Contributor

@pa-kh039 pa-kh039 commented Oct 5, 2023

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 5, 2023
@pa-kh039
Copy link
Contributor Author

pa-kh039 commented Oct 5, 2023

@tianyizheng02 @cclauss please review (PR for hacktoberfest 2023)

@cclauss
Copy link
Member

cclauss commented Oct 5, 2023

When would someone want to use this algorithm?

@pa-kh039
Copy link
Contributor Author

pa-kh039 commented Oct 5, 2023 •
edited
Loading

When would someone want to use this algorithm?

@cclauss
There are several possible use cases for this algorithm. To enlist a few:

  1. When managing a portfolio of financial assets, you might want to find the largest subset of assets where each asset's price is a multiple of another, which can help with diversification and risk management.
  2. In data analysis, you may encounter situations where you want to group data points into clusters based on some criteria, and this problem can be used to find the largest subset of data points that are related according to specific rules.

So, with some changes in it , this algorithm can be utilised at several places.

@pa-kh039 @cclauss
adding more test cases
e78e5f6 
Co-authored-by: Christian Clauss <cclauss@me.com>
pa-kh039 and others added 2 commits October 5, 2023 20:24
@pa-kh039 @cclauss
improving code for better readability
16ff978 
Co-authored-by: Christian Clauss <cclauss@me.com>
@pa-kh039 @cclauss
update
344a545 
Co-authored-by: Christian Clauss <cclauss@me.com>
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 5, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 5, 2023
@pa-kh039
Copy link
Contributor Author

pa-kh039 commented Oct 5, 2023

@cclauss Did all the changes suggested by you and all the associated changes.

@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 5, 2023
@pa-kh039
Copy link
Contributor Author

pa-kh039 commented Oct 5, 2023

@cclauss Would you like to suggest any more changes in the latest version?

@cclauss cclauss enabled auto-merge (squash) October 5, 2023 16:21
@cclauss cclauss merged commit 87494f1 into TheAlgorithms:master Oct 5, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 5, 2023
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@pa-kh039 @cclauss
@pre-commit-ci @sedatguzelsemme
largest divisible subset (TheAlgorithms#9825)
2d24497 
* largest divisible subset

* minor tweaks

* adding more test cases

Co-authored-by: Christian Clauss <cclauss@me.com>

* improving code for better readability

Co-authored-by: Christian Clauss <cclauss@me.com>

* update

Co-authored-by: Christian Clauss <cclauss@me.com>

* update

Co-authored-by: Christian Clauss <cclauss@me.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* suggested changes done, and further modfications

* final update

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update largest_divisible_subset.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update largest_divisible_subset.py

---------

Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pa-kh039 @cclauss