-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segmented sieve - doctests #9945
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ad217c6
Replacing the generator with numpy vector operations from lu_decompos…
quant12345 07dfc06
Revert "Replacing the generator with numpy vector operations from lu_…
quant12345 8a50e77
Merge branch 'TheAlgorithms:master' into master
quant12345 961e92a
Added doctests.
quant12345 9b59404
Update segmented_sieve.py
quant12345 10a46e7
Update segmented_sieve.py
quant12345 587cdc2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3df701a
Update segmented_sieve.py
quant12345 f261cba
Update segmented_sieve.py
quant12345 535fcdc
Update segmented_sieve.py
quant12345 acbac94
Update segmented_sieve.py
quant12345 9bacc25
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b173e62
Update segmented_sieve.py
quant12345 f15758c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 8c4336c
Update segmented_sieve.py
quant12345 3de3f75
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 496c9a9
ValueError: Number 22.2 must instead be a positive integer
cclauss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a doctest where the input itself is a prime number. For example,
This is to clarify whether the algorithm includes the input number itself or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition, please make sure that the function can correctly handle negative and zero inputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tianyizheng02 corrected.