Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Squareplus Activation Function #9977

Merged
merged 4 commits into from
Oct 8, 2023
Merged

Added Squareplus Activation Function #9977

merged 4 commits into from
Oct 8, 2023

Conversation

kausthub-kannan
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 7, 2023
@kausthub-kannan kausthub-kannan changed the title Squareplus Added Squareplus Activation Function Oct 7, 2023
tianyizheng02
tianyizheng02 requested changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't appear to implement the squareplus function. Both Wikipedia and the original squareplus paper state that the function is
$$f(x, b) = \frac{x + \sqrt{x^2 + b}}{2}$$

@tianyizheng02 tianyizheng02 merged commit a12b07f into TheAlgorithms:master Oct 8, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 8, 2023
tianyizheng02 added a commit to tianyizheng02/Python that referenced this pull request Oct 8, 2023
@kausthub-kannan @tianyizheng02
Added Squareplus Activation Function (TheAlgorithms#9977)
8a5220b 
* Added Squareplus Activation Function

* Added parameter beta to the function

* Fixed Squareplus Function

* Update neural_network/activation_functions/squareplus.py

---------

Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@kausthub-kannan kausthub-kannan deleted the squareplus branch October 8, 2023 19:11
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@kausthub-kannan @tianyizheng02 @sedatguzelsemme
Added Squareplus Activation Function (TheAlgorithms#9977)
ad4bd92 
* Added Squareplus Activation Function

* Added parameter beta to the function

* Fixed Squareplus Function

* Update neural_network/activation_functions/squareplus.py

---------

Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kausthub-kannan @tianyizheng02